New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default max message size #1676

Closed
ejona86 opened this Issue Apr 15, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@ejona86
Member

ejona86 commented Apr 15, 2016

Currently DEFAULT_MAX_MESSAGE_SIZE is 100 MB. That's laughably high. We should reduce it down to at least 10 MB, but 1 MB would make me feel much better.

This needs to be done cross-language.

@ejona86 ejona86 added this to the 1.0 milestone Apr 15, 2016

@hsaliak hsaliak added the P2 label Apr 26, 2016

@ejona86

This comment has been minimized.

Member

ejona86 commented Jun 9, 2016

@carl-mastrangelo, would you mind picking this up and trying to coordinate a sane default maximum size across languages? You can already increase it with configuration, and we are fine with people increasing it.

@hsaliak

This comment has been minimized.

Member

hsaliak commented Jun 10, 2016

/cc @ctiller @iamqizhao we need to finalize this before GA so the default behaviour is finalized..

@ejona86

This comment has been minimized.

Member

ejona86 commented Jun 30, 2016

@ctiller, @a11r, and I were able to agree with going with 4 MiB for now. Future work may bring it down further, but we felt pushing much below 4 MiB required helping clients and services be in sync.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.