New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.netty.handler.codec.http2.internal.hpack.Decoder removed in netty 4.1.9 Fina #2841

Closed
xiangsky opened this Issue Mar 20, 2017 · 8 comments

Comments

Projects
None yet
6 participants
@xiangsky

xiangsky commented Mar 20, 2017

Please answer these questions before submitting your issue.

What version of gRPC are you using?

1.1.2 / 1.2.0

What JVM are you using (java -version)?

java version "1.8.0_111"
Java(TM) SE Runtime Environment (build 1.8.0_111-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.111-b14, mixed mode)

What did you do?

If possible, provide a recipe for reproducing the error.

io.netty.handler.codec.http2.internal.hpack.Decoder been removed in the Netty 4.1.9 fina

What did you expect to see?

What did you see instead?

@carl-mastrangelo

This comment has been minimized.

Show comment
Hide comment
@carl-mastrangelo

carl-mastrangelo Mar 20, 2017

Member

That class was not removed, it just moved up a directory. We know, and it is the reason why we haven't upgraded to Netty 4.1.9.

Member

carl-mastrangelo commented Mar 20, 2017

That class was not removed, it just moved up a directory. We know, and it is the reason why we haven't upgraded to Netty 4.1.9.

@beihaifeiwu

This comment has been minimized.

Show comment
Hide comment
@beihaifeiwu

beihaifeiwu commented Mar 26, 2017

+1

@nmittler

This comment has been minimized.

Show comment
Hide comment
@nmittler

nmittler Mar 31, 2017

Member

@carl-mastrangelo @ejona86

I've got a fix for this that will go into Netty 4.1.10.Final (netty/netty#6589)

Also, I've got the gRPC changes necessary for the upgrade. I think I'll just hand this off so that one of you can clean it up after the Netty release and run it through your import/presubmit workflow to make sure nothing is broken. Sound good?

Member

nmittler commented Mar 31, 2017

@carl-mastrangelo @ejona86

I've got a fix for this that will go into Netty 4.1.10.Final (netty/netty#6589)

Also, I've got the gRPC changes necessary for the upgrade. I think I'll just hand this off so that one of you can clean it up after the Netty release and run it through your import/presubmit workflow to make sure nothing is broken. Sound good?

@carl-mastrangelo

This comment has been minimized.

Show comment
Hide comment
@carl-mastrangelo

carl-mastrangelo Mar 31, 2017

Member

@nmittler excellent. When 4.1.10 comes out I can merge this.

Member

carl-mastrangelo commented Mar 31, 2017

@nmittler excellent. When 4.1.10 comes out I can merge this.

@nmittler

This comment has been minimized.

Show comment
Hide comment
@nmittler

nmittler Mar 31, 2017

Member

@carl-mastrangelo SGTM, thanks!

Also, I just merged netty/netty#6589, so we'll be good to go.

Member

nmittler commented Mar 31, 2017

@carl-mastrangelo SGTM, thanks!

Also, I just merged netty/netty#6589, so we'll be good to go.

@beihaifeiwu

This comment has been minimized.

Show comment
Hide comment
@beihaifeiwu

beihaifeiwu May 1, 2017

@nmittler I have seen that netty 4.1.10 is released

beihaifeiwu commented May 1, 2017

@nmittler I have seen that netty 4.1.10 is released

@guillaumecle

This comment has been minimized.

Show comment
Hide comment
@guillaumecle

guillaumecle May 3, 2017

Any progress on this?
In netty/netty#6594, netty exposes the interface to be used by grpc for it's custom hpack decoder.

guillaumecle commented May 3, 2017

Any progress on this?
In netty/netty#6594, netty exposes the interface to be used by grpc for it's custom hpack decoder.

@eiswind

This comment has been minimized.

Show comment
Hide comment
@eiswind

eiswind May 4, 2017

+1 for spring reactive users

eiswind commented May 4, 2017

+1 for spring reactive users

@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.