Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android Interopt Test is breaking due to mockito upgrade #5523

Closed
dapengzhang0 opened this issue Apr 1, 2019 · 6 comments · Fixed by #5525
Closed

Android Interopt Test is breaking due to mockito upgrade #5523

dapengzhang0 opened this issue Apr 1, 2019 · 6 comments · Fixed by #5525
Assignees
@dapengzhang0
Milestone
1.21

Comments

@dapengzhang0
Copy link
Member

See #5484 (comment)

cc @TimvdLippe
@dapengzhang0 dapengzhang0 self-assigned this Apr 1, 2019
@dapengzhang0 dapengzhang0 added this to the 1.20 milestone Apr 1, 2019
@TimvdLippe
Copy link
Contributor

Could you provide some instructions on how I can debug this issue? We should be able to fix this by updating the Android tooling.

@TimvdLippe
Copy link
Contributor

I think you need to update

grpc-java/android-interop-testing/build.gradle

Line 9 in d8b5d84

classpath 'com.android.tools.build:gradle:3.1.2'
to at least version 3.3.0

Also note that Dexmaker is NOT deprecated and is intended to be used as mockmaker on Android.

@dapengzhang0
Copy link
Member Author

@TimvdLippe From this link (I'm not sure whether you have access to)
https://fusion.corp.google.com/projectanalysis/summary/KOKORO/prod:grpc%2Fjava%2Fmaster%2Fbranch%2Fandroid-interop
Click trigger build. This will build android-interop test for a branch or a commit sha. Unfortunately this is not part of presubmit.

@TimvdLippe
Copy link
Contributor

I can inspect the results but have no permission to trigger a new build. I do think #5523 (comment) should fix the issue.

This was referenced Apr 1, 2019
Closed
Merged
Merged
@ejona86 ejona86 mentioned this issue Apr 1, 2019
Closed
@dapengzhang0 dapengzhang0 modified the milestones: 1.20, 1.21 Apr 1, 2019
@dapengzhang0
Copy link
Member Author

Move to milestone 1.21 because android-interop-testing is not published to maven.

@dapengzhang0 dapengzhang0 mentioned this issue Apr 1, 2019
Merged
dapengzhang0 added a commit that referenced this issue Apr 2, 2019
@dapengzhang0
android/android-interop-testing/examples: upgrade android plugin
755a227 
This resolves #5523

While bumping `com.android.tools.build:gradle:3.1.2` to `3.3.0`, some other plugins/artifacts/maven repo/buildscripts have to be updated:

- gradle (wrapper) need to upgrade to 4.10.x
- protobuf gradle plugin need to bump a version compatible with gradle version.
- need add `google()` and `jcenter()` repos for android (otherwise `com.android.tools.build:aapt2:3.3.0x` and `trove4j` will not be found resp.)
- need to accept license for Android "build-tools;28.0.3" in kokoro env.
@dapengzhang0
Copy link
Member Author

v1.20.x is also failing.
https://sponge.corp.google.com/target?id=523826f1-a75e-4172-89f6-2b9d82d8b9d9&target=grpc%2Fjava%2Fv1.20.x%2Fbranch%2Fandroid-interop&searchFor=

I believe #5544 will fix that, no need to bump android gradle plugin and protobuf gradle plugin and all that.

@dapengzhang0 dapengzhang0 mentioned this issue Apr 3, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dapengzhang0 dapengzhang0

Labels
None yet
Projects
None yet
Milestone
1.21
2 participants
@dapengzhang0 @TimvdLippe