From 42f1fc2c3aa97220be01e01c7a0f8ea41d8ea88e Mon Sep 17 00:00:00 2001 From: yifeizhuang Date: Mon, 10 Apr 2023 11:15:05 -0700 Subject: [PATCH] rename to setQpsMetric --- .../src/main/java/io/grpc/services/MetricRecorder.java | 4 ++-- .../test/java/io/grpc/xds/orca/OrcaServiceImplTest.java | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/services/src/main/java/io/grpc/services/MetricRecorder.java b/services/src/main/java/io/grpc/services/MetricRecorder.java index 7a541cceeab..9bcab934bd5 100644 --- a/services/src/main/java/io/grpc/services/MetricRecorder.java +++ b/services/src/main/java/io/grpc/services/MetricRecorder.java @@ -90,14 +90,14 @@ public void clearMemoryUtilizationMetric() { /** * Update the QPS metrics data. */ - public void setQps(double value) { + public void setQpsMetric(double value) { qps = value; } /** * Clear the QPS metrics data. */ - public void clearQps() { + public void clearQpsMetric() { qps = 0; } diff --git a/xds/src/test/java/io/grpc/xds/orca/OrcaServiceImplTest.java b/xds/src/test/java/io/grpc/xds/orca/OrcaServiceImplTest.java index 1063b2bec0c..74e0143456a 100644 --- a/xds/src/test/java/io/grpc/xds/orca/OrcaServiceImplTest.java +++ b/xds/src/test/java/io/grpc/xds/orca/OrcaServiceImplTest.java @@ -143,7 +143,7 @@ public void testRequestIntervalLess() { ClientCall call = channel.newCall( OpenRcaServiceGrpc.getStreamCoreMetricsMethod(), CallOptions.DEFAULT); defaultTestService.putUtilizationMetric("buffer", 0.2); - defaultTestService.setQps(1.9); + defaultTestService.setQpsMetric(1.9); call.start(listener, new Metadata()); call.sendMessage(OrcaLoadReportRequest.newBuilder() .setReportInterval(Duration.newBuilder().setSeconds(0).setNanos(500).build()).build()); @@ -154,7 +154,7 @@ public void testRequestIntervalLess() { verify(listener).onMessage(eq(expect)); reset(listener); defaultTestService.removeUtilizationMetric("buffer0"); - defaultTestService.clearQps(); + defaultTestService.clearQpsMetric(); assertThat(fakeClock.forwardTime(500, TimeUnit.NANOSECONDS)).isEqualTo(0); verifyNoInteractions(listener); assertThat(fakeClock.forwardTime(1, TimeUnit.SECONDS)).isEqualTo(1); @@ -255,14 +255,14 @@ public void testApis() throws Exception { defaultTestService.setMemoryUtilizationMetric(goldenReport.getMemUtilization()); defaultTestService.setAllUtilizationMetrics(firstUtilization); defaultTestService.putUtilizationMetric("queue", 1.0); - defaultTestService.setQps(1239.01); + defaultTestService.setQpsMetric(1239.01); Iterator reports = OpenRcaServiceGrpc.newBlockingStub(channel) .streamCoreMetrics(OrcaLoadReportRequest.newBuilder().build()); assertThat(reports.next()).isEqualTo(goldenReport); defaultTestService.clearCpuUtilizationMetric(); defaultTestService.clearMemoryUtilizationMetric(); - defaultTestService.clearQps(); + defaultTestService.clearQpsMetric(); fakeClock.forwardTime(1, TimeUnit.SECONDS); goldenReport = OrcaLoadReport.newBuilder() .putAllUtilization(firstUtilization)