New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Abstract{ServiceName} class in compiled service class #1634
base: master
Diff settings
| @@ -157,6 +157,12 @@ protected BenchmarkServiceFutureStub build(io.grpc.Channel channel, | ||
| } | ||
| } | ||
| public static abstract class AbstractBenchmarkService implements BenchmarkService, io.grpc.stub.BindableService { | ||
Show comment
Hide comment
carl-mastrangelo
Member
|
||
| @Override public io.grpc.ServerServiceDefinition bindService() { | ||
| return BenchmarkServiceGrpc.bindService(this); | ||
| } | ||
| } | ||
| private static final int METHODID_UNARY_CALL = 0; | ||
| private static final int METHODID_STREAMING_CALL = 1; | ||
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| * Copyright 2016, Google Inc. All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions are | ||
| * met: | ||
| * | ||
| * * Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * * Redistributions in binary form must reproduce the above | ||
| * copyright notice, this list of conditions and the following disclaimer | ||
| * in the documentation and/or other materials provided with the | ||
| * distribution. | ||
| * | ||
| * * Neither the name of Google Inc. nor the names of its | ||
| * contributors may be used to endorse or promote products derived from | ||
| * this software without specific prior written permission. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
| * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
| * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
| package io.grpc.stub; | ||
| import io.grpc.ExperimentalApi; | ||
| import io.grpc.ServerServiceDefinition; | ||
| /** | ||
| * Provides a way to bind instance of service implementation to server. | ||
| * | ||
| * <p>Enables dynamic creation of {@link ServerServiceDefinition} when exact type of service class | ||
| * is unknown. | ||
| * | ||
| * <pre><code>Class<? extends BindableService> service = ...; | ||
| * ServerBuilder.forPort(...).addService(service.newInstance().bindService()); | ||
| * </code></pre></p> | ||
| * | ||
| * <p>It is used by service's abstract class generated by compiler (eg.: | ||
| * RouteGuideGrpc.AbstractRouteGuide for RouteGuide service). Service implementation classes which | ||
| * want to be "dynamically" bind should inherit from this base class.</p> | ||
| */ | ||
| @ExperimentalApi | ||
| public interface BindableService { | ||
| /** | ||
| * Creates {@link ServerServiceDefinition} object for current instance of service implementation. | ||
| * | ||
| * @return ServerServiceDefinition object. | ||
| */ | ||
| ServerServiceDefinition bindService(); | ||
| } |
I am having a hard time understanding what the value add is here. Would you be able to add examples classes that show off how this would be used? Right now this just seems to be a minor convenience class.
I am pretty reluctant to increase our API surface without some real, tangible benefit.