compiler: whitelist USER32.DLL. #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 32-bit windows grpc codegen built with protobuf 3.0.2 depends on USER32.DLL, while the previous release built with protobuf 3.0.0 didn't. Both protobuf and grpc codegen are built under msys2-mingw32. "objdump -x libprotobuf-10.dll | grep DLL" also shows the USER32.DLL dependency being brought by protobuf: 3.0.0 DLL Name: KERNEL32.dll DLL Name: msvcrt.dll DLL Name: zlib1.dll DLL Name: libgcc_s_dw2-1.dll DLL Name: libstdc++-6.dll 3.0.2 DLL Name: KERNEL32.dll DLL Name: msvcrt.dll DLL Name: USER32.dll DLL Name: zlib1.dll DLL Name: libgcc_s_dw2-1.dll DLL Name: libstdc++-6.dll While unexpected, USER32.dll is shipped with Windows so having such dependency shouldn't cause any trouble.
carl-mastrangelo
approved these changes
Nov 29, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 32-bit windows grpc codegen built with protobuf 3.0.2 depends on
USER32.DLL, while the previous release built with protobuf 3.0.0 didn't.
Both protobuf and grpc codegen are built under msys2-mingw32.
"objdump -x libprotobuf-10.dll | grep DLL" also shows the USER32.DLL
dependency being brought by protobuf:
3.0.0
DLL Name: KERNEL32.dll
DLL Name: msvcrt.dll
DLL Name: zlib1.dll
DLL Name: libgcc_s_dw2-1.dll
DLL Name: libstdc++-6.dll
3.0.2
DLL Name: KERNEL32.dll
DLL Name: msvcrt.dll
DLL Name: USER32.dll
DLL Name: zlib1.dll
DLL Name: libgcc_s_dw2-1.dll
DLL Name: libstdc++-6.dll
While unexpected, USER32.dll is shipped with Windows so having such
dependency shouldn't cause any trouble.