From f344398e4f291ecb3ec4e381f105aae91bbddf44 Mon Sep 17 00:00:00 2001 From: Eric Anderson Date: Mon, 27 Nov 2017 13:41:32 -0800 Subject: [PATCH] core: Increase server handshake timeout to 120s Previously it was 20s. 20s isn't _bad_, but may be too aggressive. Having it longer doesn't hurt us too much; we just need some bound. Since the MAX_BACKOFF on client-side is 120s, this will have client and server match, except for jitter. Although I will note that the client-side value covers more work than the server-side, such as attempting to connect to multiple hosts. --- .../main/java/io/grpc/internal/AbstractServerImplBuilder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/java/io/grpc/internal/AbstractServerImplBuilder.java b/core/src/main/java/io/grpc/internal/AbstractServerImplBuilder.java index 12795baf8fa..44cb4ff1e5a 100644 --- a/core/src/main/java/io/grpc/internal/AbstractServerImplBuilder.java +++ b/core/src/main/java/io/grpc/internal/AbstractServerImplBuilder.java @@ -73,7 +73,7 @@ public List getServices() { DecompressorRegistry.getDefaultInstance(); private static final CompressorRegistry DEFAULT_COMPRESSOR_REGISTRY = CompressorRegistry.getDefaultInstance(); - private static final long DEFAULT_HANDSHAKE_TIMEOUT_MILLIS = TimeUnit.SECONDS.toMillis(20); + private static final long DEFAULT_HANDSHAKE_TIMEOUT_MILLIS = TimeUnit.SECONDS.toMillis(120); final InternalHandlerRegistry.Builder registryBuilder = new InternalHandlerRegistry.Builder();