core,testing: deprecate passing ServerCall to StatsTraceContext #3912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, pass a ServerCallInfo object containing the interesting bits of info. This lets us modify the call handler for binary logging, but still provide the original info to the StatsTraceContext API.
Contributor
Author
|
This PR is required for #3879 |
Contributor
Author
|
@zhangkun83 PTAL |
zhangkun83
reviewed
Jan 17, 2018
| * handler. | ||
| */ | ||
| @SuppressWarnings("deprecation") | ||
| public void serverCallStarted(final ServerCallInfo<?, ?> callInfo) { |
Contributor
There was a problem hiding this comment.
Argument doesn't need to be final.
| public boolean isCancelled() { | ||
| return isCancelled; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
ServerCallInfo is passed only to serverCallStarted(). isReady() and isCancelled() don't seem to be useful at that point. We should probably remove them.
zpencer
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Contributor
Author
|
@zhangkun83 ping The GAE failure is due to an unrelated issue #4000 |
zhangkun83
reviewed
Jan 26, 2018
| private final Attributes attributes; | ||
| private final String authority; | ||
|
|
||
| ServerCallInfo( |
Contributor
There was a problem hiding this comment.
Hmm... if you lock down the constructor, how do people outside of gRPC unit-test their own ServerStreamTracers?
Maybe this should be an abstract class, and put the impl in io/grpc/internal.
zhangkun83
reviewed
Jan 26, 2018
| /** | ||
| * An implementation of {@link ServerCallInfo}. | ||
| */ | ||
| public final class ServerCallInfoImpl<ReqT, RespT> extends ServerCallInfo<ReqT, RespT> { |
Contributor
There was a problem hiding this comment.
This can be package-private.
zhangkun83
approved these changes
Jan 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, pass a ServerCallInfo object containing the interesting bits
of info. This lets us modify the call handler for binary logging, but
still provide the original info to the StatsTraceContext API.
Updated unit tests and existing code to use new API
Modified existing tests that were overspecified, and failed because of new but harmless mock interactions.