core,services: v1 binlog #4846
Merged
core,services: v1 binlog #4846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Log using new proto definition - Remove io.grpc.BinaryLog.CallId because a call ID is now an AtomicLong - Add the concept of "always included" and "never included" metadata keys. This is needed because grpc-status-details-bin is already logged in the binlog msg, and we will log grpc-trace-bin for the census info. - unit tests are effectively rewritten
ejona86
reviewed
Sep 25, 2018
| */ | ||
| class BinaryLogProviderImpl extends BinaryLogProvider { | ||
| // avoid using 0 because proto3 long fields default to 0 when unset | ||
| private static final AtomicLong counter = new AtomicLong(1); |
Contributor
Author
There was a problem hiding this comment.
In an effort to simplify the call id for the grfc, I made it so that the call id is a unique uint64. I didn't want the same ID to appear in different files if multiple log files are used. https://github.com/grpc/proposal/blame/master/A16-binary-logging.md#L107
|
|
||
| TimeProvider SYSTEM_TIME_PROVIDER = new TimeProvider() { | ||
| final long offsetNanos = | ||
| TimeUnit.MILLISECONDS.toNanos(System.currentTimeMillis()) - System.nanoTime(); |
Member
There was a problem hiding this comment.
If the clock changes, then the timestamps will be incorrect. Is that what is supposed to happen?
Contributor
Author
There was a problem hiding this comment.
Let's simply report the current system time. There's no requirement to have a high resolution timestamp.
ejona86
approved these changes
Sep 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keys. This is needed because grpc-status-details-bin is already
logged in the binlog msg, and we will log grpc-trace-bin for the
census info.