Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Trim trailing dot from SRV hostnames #5006

Merged
merged 1 commit into from Oct 27, 2018

Conversation

@ejona86
Copy link
Member

commented Oct 26, 2018

The trailing dot denotes the hostname to be absolute. It is fine to
leave, but removing it makes the authority match the more common form
and hopefully reduces confusion.

This happens to works around SNI failures caused when using gRPC-LB,
since SNI prohibits the trailing dot. However, that is not the reason
for this change as we have to support users directly providing a
hostname with the trailing dot anyway (and doing so is not hard).

See #4912


This is fundamentally a 4 line change, but with more changes to make it testable.

core: Trim trailing dot from SRV hostnames
The trailing dot denotes the hostname to be absolute. It is fine to
leave, but removing it makes the authority match the more common form
and hopefully reduces confusion.

This happens to works around SNI failures caused when using gRPC-LB,
since SNI prohibits the trailing dot. However, that is not the reason
for this change as we have to support users directly providing a
hostname with the trailing dot anyway (and doing so is not hard).

See #4912
@carl-mastrangelo
Copy link
Contributor

left a comment

LGTM

@ejona86 ejona86 merged commit e5339d2 into grpc:master Oct 27, 2018

13 checks passed

Android Kokoro build finished
Details
Bazel Kokoro build finished
Details
GAE Interop Kokoro build finished
Details
Linux artifacts Kokoro build finished
Details
Macos Kokoro build finished
Details
Windows Kokoro build finished
Details
android/apk_diff New APK size in bytes: 1,014,321 (delta: 0)
android/dex_diff New DEX reference count: 12,831 (delta: 0)
cla/linuxfoundation ejona86 authorized
Details
codecov/patch 87.09% of diff hit (target 80%)
Details
codecov/project 83.44% (+0.22%) compared to d7af1ee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on srv-trailing-dot at 87.645%
Details

@ejona86 ejona86 deleted the ejona86:srv-trailing-dot branch Oct 27, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.