Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okhttp: add verbose logging for OkHttp HTTP/2 frame content #5488

Merged
merged 12 commits into from Apr 4, 2019

Conversation

@voidzcy
Copy link
Contributor

commented Mar 20, 2019

Add a logger in OkHttp transport layer for verbose logging output to show HTTP/2 frame content. Similar logging exists in Netty framework. Solves #3281

@voidzcy voidzcy requested a review from dapengzhang0 Mar 20, 2019

@voidzcy

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

Here is how the log looks like

Screen Shot 2019-03-20 at 2 53 33 PM

@voidzcy voidzcy force-pushed the voidzcy:feature/okhttp_logging_frame_info branch from 8f0c2a3 to 89c031e Mar 20, 2019

@dapengzhang0

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

@voidzcy Please do not force-push, push more commits to show incremental diffs.

@voidzcy voidzcy force-pushed the voidzcy:feature/okhttp_logging_frame_info branch from 89c031e to 4e63821 Mar 20, 2019

@voidzcy voidzcy requested a review from dapengzhang0 Mar 21, 2019

@voidzcy voidzcy force-pushed the voidzcy:feature/okhttp_logging_frame_info branch from 720a448 to 15e47bc Mar 23, 2019

@dapengzhang0
Copy link
Member

left a comment

It's better to have tests. You might need inject a fake/mock logger.

@voidzcy voidzcy force-pushed the voidzcy:feature/okhttp_logging_frame_info branch from 7ac8dfc to 5d86cb9 Apr 2, 2019

@voidzcy voidzcy requested a review from dapengzhang0 Apr 3, 2019

@dapengzhang0
Copy link
Member

left a comment

LGTM

@voidzcy voidzcy force-pushed the voidzcy:feature/okhttp_logging_frame_info branch from 590160d to 870d396 Apr 4, 2019

@voidzcy voidzcy merged commit 0db0c63 into grpc:master Apr 4, 2019

13 checks passed

Android Kokoro build finished
Details
Bazel Kokoro build finished
Details
GAE Interop Kokoro build finished
Details
Linux artifacts Kokoro build finished
Details
Macos Kokoro build finished
Details
Windows Kokoro build finished
Details
android/apk_diff New APK size in bytes: 1,024,329 (delta: 1,592)
android/dex_diff New DEX reference count: 12,808 (delta: 30)
cla/linuxfoundation voidzcy authorized
Details
codecov/patch 90.81% of diff hit (target 80%)
Details
codecov/project 82.43% (+0.11%) compared to faf6ff9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 86.905%
Details

@lock lock bot locked as resolved and limited conversation to collaborators Jul 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.