android-interop-testing/examples: upgrade android plugin #5525
Conversation
| @@ -36,6 +36,8 @@ android { | |||
| } | |||
|
|
|||
| repositories { | |||
| google() | |||
There was a problem hiding this comment.
I had a build error "Could not find com.android.tools.build:aapt2:3.3.0-5013011".
There was a problem hiding this comment.
That explains google, but why jcenter?
There was a problem hiding this comment.
After fixing "Could not find com.android.tools.build:aapt2:3.3.0-5013011" by adding google(), there is another artifact missing Could not find org.jetbrains.trove4j:trove4j.
There was a problem hiding this comment.
I see. Then go ahead and remove mavenCentral(), as it wouldn't be needed if jcenter() is available (and earlier in the list).
There was a problem hiding this comment.
Hmmm... I'm not as sure if we want to remove mavenCentral() in the examples though, since there's been problems with jcenter not having new grpc releases. Meh. I guess you can leave them both.
There was a problem hiding this comment.
The problems with jcenter not having new grpc releases becomes a problem now: Android from now on need jcenter.
There was a problem hiding this comment.
Oh, I see, having both jcenter (for trove4j) and mavenCentral (for grpc new release).
| @@ -15,6 +15,9 @@ export LDFLAGS=-L/tmp/protobuf/lib | |||
| export CXXFLAGS=-I/tmp/protobuf/include | |||
| export LD_LIBRARY_PATH=/tmp/protobuf/lib | |||
| export OS_NAME=$(uname) | |||
| export ANDROID_SDK_HOME=/opt/android-sdk/current | |||
There was a problem hiding this comment.
ANDROID_HOME is already defined with this value.
There was a problem hiding this comment.
Is ANDROID_HOME already defined for both android and android-interop-test in kokoru env?
There was a problem hiding this comment.
Kokoro defines ANDROID_HOME. I think the android gradle plugin itself requires ANDROID_HOME to be set.
| @@ -15,6 +15,9 @@ export LDFLAGS=-L/tmp/protobuf/lib | |||
| export CXXFLAGS=-I/tmp/protobuf/include | |||
| export LD_LIBRARY_PATH=/tmp/protobuf/lib | |||
| export OS_NAME=$(uname) | |||
| export ANDROID_SDK_HOME=/opt/android-sdk/current | |||
|
|
|||
| echo y | ${ANDROID_SDK_HOME}/tools/bin/sdkmanager "build-tools;28.0.3" | |||
There was a problem hiding this comment.
Hmm... this will actually install this particular version. I sort of question if it would be better to drop the right MD5s into licenses/android-sdk-license
There was a problem hiding this comment.
linux-artifacts is also failing. The same issue. http://g/kokoro-users/_P4EAOWi-ko/PRFQvowPDgAJ
There was a problem hiding this comment.
I sort of question if it would be better to drop the right MD5s into licenses/android-sdk-license
I don't understand how to do that/ how that works.
There was a problem hiding this comment.
Hmm... it seems the license handling is done differently these days. Previously after you accepted a licenses you could get any of the binaries with that license. But that doesn't seem to work any more. So this seems fine.
|
Now Android Interop is passing in kokoro. |
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.9-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.1-all.zip | |||
There was a problem hiding this comment.
-bin (to match the others, and because it is smaller)
This resolves #5523
While bumping
com.android.tools.build:gradle:3.1.2to3.3.0, some other plugins/artifacts/maven repo/buildscripts have to be updated:google()andjcenter()repos for android (otherwisecom.android.tools.build:aapt2:3.3.0xandtrove4jwill not be found resp.)