diff --git a/xds/src/main/java/io/grpc/xds/CdsLoadBalancer.java b/xds/src/main/java/io/grpc/xds/CdsLoadBalancer.java index 99568b87477..5c8cb78e20a 100644 --- a/xds/src/main/java/io/grpc/xds/CdsLoadBalancer.java +++ b/xds/src/main/java/io/grpc/xds/CdsLoadBalancer.java @@ -48,7 +48,7 @@ import javax.annotation.Nullable; /** - * Load balancer for experimental_cds LB policy. + * Load balancer for cds_experimental LB policy. */ public final class CdsLoadBalancer extends LoadBalancer { private final ChannelLogger channelLogger; diff --git a/xds/src/main/java/io/grpc/xds/CdsLoadBalancerProvider.java b/xds/src/main/java/io/grpc/xds/CdsLoadBalancerProvider.java index d70e9bf81d5..eb1abb1be70 100644 --- a/xds/src/main/java/io/grpc/xds/CdsLoadBalancerProvider.java +++ b/xds/src/main/java/io/grpc/xds/CdsLoadBalancerProvider.java @@ -31,12 +31,12 @@ /** * The provider for the "cds" balancing policy. This class should not be directly referenced in * code. The policy should be accessed through {@link io.grpc.LoadBalancerRegistry#getProvider} - * with the name "cds" (currently "experimental_cds"). + * with the name "cds" (currently "cds_experimental"). */ @Internal public class CdsLoadBalancerProvider extends LoadBalancerProvider { - static final String CDS_POLICY_NAME = "experimental_cds"; + static final String CDS_POLICY_NAME = "cds_experimental"; private static final String CLUSTER_KEY = "cluster"; @Override diff --git a/xds/src/main/java/io/grpc/xds/XdsNameResolver.java b/xds/src/main/java/io/grpc/xds/XdsNameResolver.java index 41b646af5d2..207db3473ce 100644 --- a/xds/src/main/java/io/grpc/xds/XdsNameResolver.java +++ b/xds/src/main/java/io/grpc/xds/XdsNameResolver.java @@ -139,7 +139,7 @@ public void onConfigChanged(ConfigUpdate update) { String serviceConfig = "{\n" + " \"loadBalancingConfig\": [\n" + " {\n" - + " \"experimental_cds\": {\n" + + " \"cds_experimental\": {\n" + " \"cluster\": \"" + update.getClusterName() + "\"\n" + " }\n" + " }\n" diff --git a/xds/src/test/java/io/grpc/xds/XdsNameResolverTest.java b/xds/src/test/java/io/grpc/xds/XdsNameResolverTest.java index 7819813f0ce..9740e56459b 100644 --- a/xds/src/test/java/io/grpc/xds/XdsNameResolverTest.java +++ b/xds/src/test/java/io/grpc/xds/XdsNameResolverTest.java @@ -263,9 +263,9 @@ public void resolve_foundResource() { List> rawLbConfigs = (List>) serviceConfig.get("loadBalancingConfig"); Map lbConfig = Iterables.getOnlyElement(rawLbConfigs); - assertThat(lbConfig.keySet()).containsExactly("experimental_cds"); + assertThat(lbConfig.keySet()).containsExactly("cds_experimental"); @SuppressWarnings("unchecked") - Map rawConfigValues = (Map) lbConfig.get("experimental_cds"); + Map rawConfigValues = (Map) lbConfig.get("cds_experimental"); assertThat(rawConfigValues).containsExactly("cluster", clusterName); } @@ -308,8 +308,8 @@ public void resolve_resourceUpdated() { List> rawLbConfigs = (List>) serviceConfig.get("loadBalancingConfig"); Map lbConfig = Iterables.getOnlyElement(rawLbConfigs); - assertThat(lbConfig.keySet()).containsExactly("experimental_cds"); - Map rawConfigValues = (Map) lbConfig.get("experimental_cds"); + assertThat(lbConfig.keySet()).containsExactly("cds_experimental"); + Map rawConfigValues = (Map) lbConfig.get("cds_experimental"); assertThat(rawConfigValues).containsExactly("cluster", "cluster-foo.googleapis.com"); // Simulate receiving another LDS response that tells client to do RDS. @@ -331,8 +331,8 @@ public void resolve_resourceUpdated() { serviceConfig = result.getAttributes().get(GrpcAttributes.NAME_RESOLVER_SERVICE_CONFIG); rawLbConfigs = (List>) serviceConfig.get("loadBalancingConfig"); lbConfig = Iterables.getOnlyElement(rawLbConfigs); - assertThat(lbConfig.keySet()).containsExactly("experimental_cds"); - rawConfigValues = (Map) lbConfig.get("experimental_cds"); + assertThat(lbConfig.keySet()).containsExactly("cds_experimental"); + rawConfigValues = (Map) lbConfig.get("cds_experimental"); assertThat(rawConfigValues).containsExactly("cluster", "cluster-blade.googleapis.com"); } @@ -367,9 +367,9 @@ public void resolve_resourceNewlyAdded() { List> rawLbConfigs = (List>) serviceConfig.get("loadBalancingConfig"); Map lbConfig = Iterables.getOnlyElement(rawLbConfigs); - assertThat(lbConfig.keySet()).containsExactly("experimental_cds"); + assertThat(lbConfig.keySet()).containsExactly("cds_experimental"); @SuppressWarnings("unchecked") - Map rawConfigValues = (Map) lbConfig.get("experimental_cds"); + Map rawConfigValues = (Map) lbConfig.get("cds_experimental"); assertThat(rawConfigValues).containsExactly("cluster", "cluster-foo.googleapis.com"); }