Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alts: do not exclude opencensus-api from google-oauth2's transitive dependencies #6607

Merged

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Jan 15, 2020

Previously grpc-core pulls in opencensus-api and we prefer that over google-oauth2's. After #6577, grpc-core no longer depends on opencensus-api, this exclusion should be removed.

Note: interop-testing depends on both grpc-census and grpc-alts, both of which will pull in opencensus-api dependency. Currently they depends on the same version of opencensus-api, but we should probably fix it.

@voidzcy voidzcy requested a review from ejona86 Jan 15, 2020
@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Jan 15, 2020
@voidzcy voidzcy merged commit cb4a7fb into grpc:master Jan 15, 2020
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Jan 15, 2020
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label Jan 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants