Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the ServerCallHandler API contract. #8339

Merged
merged 4 commits into from Jul 26, 2021

Conversation

jdcormie
Copy link
Member

@jdcormie jdcormie commented Jul 23, 2021

  • Focus the summary fragment
  • Clarify that implementations don't just have access to "call" and "headers" while running -- they in fact take ownership of these arguments from the caller.
  • Discuss the owner's obligation to close()
  • Make explicit the caller's obligation to the returned Listener.

jdcormie added 3 commits Jul 23, 2021
- Focus the summary fragment
- Clarify that implementations don't just have access to "call" and
"headers" while running -- they in fact take ownership of these
arguments from the caller.
- Make explicit the caller's obligation to the returned Listener.
- Clarify that "{@code call} will be closed with an error" is actually
an obligation placed on the caller (who may be a user-defined
ServerInterceptor).
api/src/main/java/io/grpc/ServerCallHandler.java Outdated Show resolved Hide resolved
@jdcormie jdcormie merged commit ecac0da into grpc:master Jul 26, 2021
14 checks passed
@jdcormie jdcormie deleted the api-javadoc-3 branch Jul 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants