Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub: Mark Stub-based MetadataUtils methods deprecated #8395

Merged
merged 2 commits into from Aug 6, 2021

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Aug 6, 2021

We don't want other APIs to copy the stub-based API to attach the
interceptor. The API has a shorter name, but isn't actually all that
easier to use and isn't fluent like using the interceptor API.

These are very old methods, so we won't be quick to delete them. Seems
we should have them deprecated at least a year or two; they are easy to
maintain in the mean time.

See API Review notes in #1789

@ejona86 ejona86 requested a review from YifeiZhuang Aug 6, 2021
We don't want other APIs to copy the stub-based API to attach the
interceptor. The API has a shorter name, but isn't actually all that
easier to use and isn't fluent like using the interceptor API.

These are _very_ old methods, so we won't be quick to delete them. Seems
we should have them deprecated at least a year or two; they are easy to
maintain in the mean time.

See API Review notes in grpc#1789
@ejona86 ejona86 force-pushed the metadata-utils-deprecated branch from 0fef093 to 45a8570 Compare Aug 6, 2021
@ejona86 ejona86 merged commit 20ac199 into grpc:master Aug 6, 2021
14 checks passed
@ejona86 ejona86 deleted the metadata-utils-deprecated branch Aug 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants