Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native: add new Node and Electron versions, bump version #1615

Merged
merged 4 commits into from Nov 5, 2020

Conversation

@murgatroid99
Copy link
Member

@murgatroid99 murgatroid99 commented Oct 29, 2020

A couple of previous changes set the package.json file out of sync with the template and build.yaml, so I corrected that here.

Also add a note in the README specifying the latest version of Node and Electron that we support. We will only have to update that a few times before we stop updating the version support entirely.

@murgatroid99 murgatroid99 requested a review from nicolasnoble Oct 29, 2020
@murgatroid99 murgatroid99 merged commit e959c55 into grpc:grpc@1.24.x Nov 5, 2020
312 of 321 checks passed
@murgatroid99 murgatroid99 mentioned this pull request Nov 9, 2020
@kurayama
Copy link

@kurayama kurayama commented Nov 10, 2020

@murgatroid99 since this PR increments the version to 1.24.4, will a tag be released soon in github/npm?

@murgatroid99
Copy link
Member Author

@murgatroid99 murgatroid99 commented Nov 10, 2020

I am trying to get a build to succeed. When that happens, I will publish a new version.

@jmeinke
Copy link

@jmeinke jmeinke commented Feb 3, 2021

@murgatroid99 Could you maybe add electron 10.3 / 11 to the build targets for prebuilds? This would be awesome!
Please also see the problematic situation we are dealing with here: #1158 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants