Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create prebuilts for native electron 10 and 11 #1684

Merged
merged 5 commits into from Feb 8, 2021

Conversation

@jmeinke
Copy link

@jmeinke jmeinke commented Feb 4, 2021

Because of this issue, we can't rely on grpc-js: #1158 (comment)
Therefore, it would be great if you could release a grpc native version with prebuilt binaries for Electron 10.3 or Electron v11.

@linux-foundation-easycla
Copy link

@linux-foundation-easycla linux-foundation-easycla bot commented Feb 4, 2021

CLA Signed

The committers are authorized under a signed CLA.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@murgatroid99
Copy link
Member

@murgatroid99 murgatroid99 commented Feb 4, 2021

It looks like some build issues have appeared since we last used this build script. I think it will help if you change setup-node to version 2 in both of the places it appears in the workflow file.

@murgatroid99
Copy link
Member

@murgatroid99 murgatroid99 commented Feb 5, 2021

It looks like it will also be necessary to upgrade setup-msbuild to version 1.0.2 in the two places it appears.

@jmeinke jmeinke force-pushed the native_electron_10_and_11 branch from 6c26e9c to 69be33c Feb 6, 2021
@jmeinke jmeinke force-pushed the native_electron_10_and_11 branch from 1a534cf to f73b869 Feb 6, 2021
@jmeinke
Copy link
Author

@jmeinke jmeinke commented Feb 8, 2021

@murgatroid99 The build was successful 🎉 Thanks for your help on fixing the build issues - it would be great if you could release this soon-ish 😃

@nicograef
Copy link

@nicograef nicograef commented Feb 8, 2021

This PR would help us a lot!
Thanks for your work @jmeinke and @murgatroid99

@murgatroid99 murgatroid99 merged commit ea5b04e into grpc:grpc@1.24.x Feb 8, 2021
341 checks passed
@jmeinke
Copy link
Author

@jmeinke jmeinke commented Feb 9, 2021

@murgatroid99 Could you please release the version to NPM. Thank you!

@murgatroid99
Copy link
Member

@murgatroid99 murgatroid99 commented Feb 9, 2021

It's out now.

@jmeinke
Copy link
Author

@jmeinke jmeinke commented Feb 10, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants