Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: stricter function check than instanceof #1759

Merged
merged 1 commit into from Apr 20, 2021
Merged

grpc: stricter function check than instanceof #1759

merged 1 commit into from Apr 20, 2021

Conversation

@zereraz
Copy link
Contributor

@zereraz zereraz commented Apr 20, 2021

instanceof Function does not work in different contexts, in this case the callback to the end of stream is not called, I am using it for haraka plugin, similar to #204 and #795
Doing it similar to underscorejs.

instanceof Function fails when run in different contexts, this check allows it to work in normal as well as vm context.
@murgatroid99 murgatroid99 merged commit a5f01fb into grpc:grpc@1.24.x Apr 20, 2021
14 of 341 checks passed
@zereraz zereraz deleted the grpc@1.24.x branch Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants