Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Electron 4.2 artifacts #939

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@CapOM
Copy link
Contributor

@CapOM CapOM commented Jul 6, 2019

4.0 and 4.1 were there but not 4.2

#937

4.0 and 4.1 were there but not 4.2

grpc#937
@thelinuxfoundation
Copy link

@thelinuxfoundation thelinuxfoundation commented Jul 6, 2019

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@CapOM CapOM closed this Jul 6, 2019
@CapOM CapOM reopened this Jul 6, 2019
@CapOM
Copy link
Contributor Author

@CapOM CapOM commented Jul 8, 2019

Hi @nicolasnoble , please take a look, thx!

@murgatroid99 murgatroid99 changed the base branch from master to grpc@1.22.x Jul 8, 2019
@murgatroid99 murgatroid99 changed the base branch from grpc@1.22.x to master Jul 8, 2019
@murgatroid99
Copy link
Member

@murgatroid99 murgatroid99 commented Jul 8, 2019

Thank you for helping with this. It would be even more helpful to have a PR with this change against the grpc@1.22.x branch so that we can publish the new binaries for that version.

@murgatroid99 murgatroid99 merged commit fd91a29 into grpc:master Jul 8, 2019
19 checks passed
@CapOM
Copy link
Contributor Author

@CapOM CapOM commented Jul 8, 2019

@murgatroid99 backport submitted #944 .
Can I send PR for 1.20.x and 1.21.x ?

@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants