Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in makeServerStreamRequest return type (grpc-native-core) #983

merged 1 commit into from Aug 6, 2019

Fix typo in makeServerStreamRequest return type (grpc-native-core) #983

merged 1 commit into from Aug 6, 2019


Copy link

@esilkensen esilkensen commented Aug 4, 2019

The makeServerStreamRequest return type in grpc-native-core is currently ClientReadableStream<RequestType>; this PR updates it to ClientReadableStream<ResponseType>.

Copy link

@thelinuxfoundation thelinuxfoundation commented Aug 4, 2019

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

CLA GitHub bot

@murgatroid99 murgatroid99 merged commit d2d6606 into grpc:master Aug 6, 2019
19 checks passed
@esilkensen esilkensen deleted the grpc-native-core-typo branch Aug 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants