Skip to content

Add new GRPCClient object #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add new GRPCClient object #1727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75a06e3
Add Client object
gjcairo Nov 28, 2023
7d63e04
Rename to GRPCClient
gjcairo Nov 28, 2023
b64dfcd
Add tests
gjcairo Nov 29, 2023
f568af3
PR changes
gjcairo Nov 29, 2023
33f3c70
Change method config to have defaults and overrides
gjcairo Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
290 changes: 0 additions & 290 deletions Sources/GRPCCore/Call/Client/ClientRPCExecutionConfiguration.swift
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions Sources/GRPCCore/Call/Client/ClientRPCExecutionConfigurationCollection.swift
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions Sources/GRPCCore/Call/Client/Internal/ClientRPCExecutor+HedgingExecutor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ extension ClientRPCExecutor {
@usableFromInline
let transport: Transport
@usableFromInline
let policy: HedgingPolicy
let policy: GRPCClient.MethodConfiguration.HedgingPolicy
@usableFromInline
let timeout: Duration?
@usableFromInline
Expand All @@ -45,7 +45,7 @@ extension ClientRPCExecutor {
@inlinable
init(
transport: Transport,
policy: HedgingPolicy,
policy: GRPCClient.MethodConfiguration.HedgingPolicy,
timeout: Duration?,
interceptors: [any ClientInterceptor],
serializer: Serializer,
Expand Down Expand Up @@ -420,7 +420,7 @@ extension ClientRPCExecutor.HedgingExecutor {
private(set) var hasUsableResponse: Bool

@inlinable
init(policy: HedgingPolicy) {
init(policy: GRPCClient.MethodConfiguration.HedgingPolicy) {
self._maximumAttempts = policy.maximumAttempts
self.attempt = 1
self.hasUsableResponse = false
Expand Down
Loading