New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quickstart.md #1159

Merged

ejona86 merged 1 commit into grpc:main from dalinaum:patch-1

Jul 10, 2023

Contributor

dalinaum commented Jul 9, 2023

Updated example code that doesn't use Builder. The current example code doesn't use Builder.

https://github.com/grpc/grpc-kotlin/blob/master/examples/server/src/main/kotlin/io/grpc/examples/helloworld/HelloWorldServer.kt#L49 https://github.com/grpc/grpc-kotlin/blob/master/examples/client/src/main/kotlin/io/grpc/examples/helloworld/HelloWorldClient.kt#L29


          Update quickstart.md

b7fb7c5

Updated example code that doesn't use Builder. The current example code doesn't use Builder.

https://github.com/grpc/grpc-kotlin/blob/master/examples/server/src/main/kotlin/io/grpc/examples/helloworld/HelloWorldServer.kt#L49
https://github.com/grpc/grpc-kotlin/blob/master/examples/client/src/main/kotlin/io/grpc/examples/helloworld/HelloWorldClient.kt#L29

linux-foundation-easycla bot commented Jul 9, 2023 •

edited

Loading

The committers listed above are authorized under a signed CLA.

✅ login: dalinaum / name: LYK (b7fb7c5)

Contributor Author

dalinaum commented Jul 9, 2023

The CLA has now been signed.

ejona86 requested a review from jamesward

July 10, 2023 15:31

jamesward approved these changes

View reviewed changes

dalinaum requested a review from jamesward

July 10, 2023 15:38

Contributor Author

dalinaum commented Jul 10, 2023

@jamesward Oops. I'm sorry I clicked rereview by mistake.

ejona86 approved these changes

View reviewed changes

ejona86 merged commit 9fca032 into grpc:main

dalinaum deleted the patch-1 branch

July 11, 2023 05:42

dfawley pushed a commit to dfawley/grpc.io that referenced this pull request


          kotlin: Update quickstart.md (grpc#1159)

dad8d6f

Updated example code that doesn't use Builder. The current example code doesn't use Builder.

https://github.com/grpc/grpc-kotlin/blob/master/examples/server/src/main/kotlin/io/grpc/examples/helloworld/HelloWorldServer.kt#L49
https://github.com/grpc/grpc-kotlin/blob/master/examples/client/src/main/kotlin/io/grpc/examples/helloworld/HelloWorldClient.kt#L29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet