Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile does not install pkg-config file for libaddress_sorting #16345

Closed
jtattermusch opened this issue Aug 14, 2018 · 3 comments
Closed

Makefile does not install pkg-config file for libaddress_sorting #16345

jtattermusch opened this issue Aug 14, 2018 · 3 comments

Comments

@jtattermusch
Copy link
Contributor

See #15166.

@jtattermusch jtattermusch added lang/c++ release notes: no Indicates if PR should not be in release notes labels Aug 14, 2018
@jtattermusch jtattermusch self-assigned this Aug 14, 2018
@jtattermusch
Copy link
Contributor Author

@coryan as I understand it, this is a problem when trying to link grpc/grpc++ statically (dynamic linking works as demonstrated by https://github.com/grpc/grpc/blob/master/test/distrib/cpp/run_distrib_test_routeguide.sh) - can you provide an example of such build? Ideally I'd like to set up a test so we don't run into this again.

@jtattermusch jtattermusch added kind/bug priority/P2 and removed release notes: no Indicates if PR should not be in release notes labels Aug 14, 2018
@coryan
Copy link
Contributor

coryan commented Aug 15, 2018

I created a little test that links things statically, you may need to adapt it to your needs. The attached tarball has a simple Makefile, and a Dockerfile to reproduce all the build steps.

There is some good news (maybe), the libgrpc++.a library seems to include the contents of the libaddress_sorting.a library. If that was intentional, then you would not need to add libaddress_sorting to any pkg-config files.

Do not hesitate to contact me if you have more questions (I am a Googler btw, so you should be able to find me inside Google too).

@stale
Copy link

stale bot commented Sep 4, 2019

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 180 days. It will be closed automatically if no further update occurs in 1 day. Thank you for your contributions!

@stale stale bot closed this as completed Sep 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants