Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name resolver support for C#/Android missing #19874

Closed
Falco20019 opened this issue Aug 7, 2019 · 5 comments
Closed

Name resolver support for C#/Android missing #19874

Falco20019 opened this issue Aug 7, 2019 · 5 comments
Assignees
Labels
disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! kind/enhancement lang/C# platform/Android priority/P3

Comments

@Falco20019
Copy link
Contributor

What version of gRPC and what language are you using?

GRPC 1.19.0 C# from NuGet package

What operating system (Linux, Windows,...) and version?

Android 7.0

What runtime / compiler are you using (e.g. python version or version of gcc)

  • C# compiler from within VS2019
  • Xamarin.Android 9.5

What did you do?

Access dns://localhost:8001/my-service

What did you expect to see?

Resolve the DNS through c-ares.

What did you see instead?

c-ares on Android is disabled as of #18046

Anything else we should know about your project / environment?

This is a follow-up for #11879

We still need an option to resolve names with C#. We are still not able to write our own name resolver. For our .NET Core application on Windows, we just use c-ares and GRPCLB to resolve the names to the dynamic endpoint. On Android, we can't resolve the name right now at all since we are still not allowed to configure a specific DNS server on the devices in the customers infrastructure.

Are there any news on adding custom name resolvers to C-Core from C#?

@gnossen
Copy link
Contributor

gnossen commented Aug 7, 2019

CC @lidizheng

@apolcyn
Copy link
Contributor

apolcyn commented Aug 8, 2019

cc @markdroth about the name resolver core API

FWIW the use of c-ares on Android was paused due to the issue brought up and fixed in c-ares/c-ares#148, which hasn't made it into a c-ares release tag yet (last I checked). c-ares on Android is currently prevented at compile time, though for experimental purposes, I could imagine that disabling happen at runtime, with switch to turn it on.

@stale
Copy link

stale bot commented Feb 4, 2020

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 180 days. It will be closed automatically if no further update occurs in 1 day. Thank you for your contributions!

@Falco20019
Copy link
Contributor Author

What’s the state here?

@stale stale bot removed the disposition/stale label Feb 4, 2020
@jtattermusch jtattermusch removed their assignment Feb 6, 2020
@yashykt
Copy link
Member

yashykt commented Mar 12, 2020

C-Core itself has not exposed a proper stable API for adding name resolvers. (Though none of C Core is actually stable API.) C-Core does have ways to add resolvers to it though. Please refer to fake_resolver.h and fake_resolver.cc for details on how one might go about implementing their own resolver. Though, it probably won't be an ideal solution since you would probably need to fork your own copy of gRPC.

It also looks like the root issue here is c-ares support for those platforms. It looks like fixing that hasn't seen much attention. Hence, I am going to mark this as disposition/help wanted for fixing c-ares support for those platforms, though I'm not sure if there's anything gRPC specific we can do here. I am also going to close this, since this has gotten stale. This can be re-opened if someone decides to implement this.

@yashykt yashykt closed this as completed Mar 12, 2020
@yashykt yashykt added priority/P3 disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! kind/enhancement and removed kind/question priority/P2 labels Mar 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! kind/enhancement lang/C# platform/Android priority/P3
Projects
None yet
Development

No branches or pull requests

5 participants