Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error Overflow Bug #10492

Merged
merged 2 commits into from Apr 7, 2017

Conversation

Projects
None yet
4 participants
@ncteisen
Copy link
Contributor

commented Apr 5, 2017

Errors now drop and log data when they are too full. Added the fuzzer that caught this. Also added a new test case to error_test to hit some of this new functionality.

@googlebot googlebot added the cla: yes label Apr 5, 2017

@ncteisen ncteisen changed the title Fix Error verflow bug Fix Error Overflow Bug Apr 5, 2017

@ncteisen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2017

@ncteisen ncteisen force-pushed the ncteisen:error-overflow branch from 4610d2a to 5294d90 Apr 6, 2017

@ncteisen ncteisen force-pushed the ncteisen:error-overflow branch from 5294d90 to c6ec115 Apr 6, 2017

@grpc-kokoro

This comment has been minimized.

Copy link

commented Apr 6, 2017

No significant performance differences
clang fmt
If I had a nickle...
@grpc-kokoro

This comment has been minimized.

Copy link

commented Apr 6, 2017

No significant performance differences
@ncteisen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2017

Failures: #9804, Docker python flake

@ncteisen ncteisen merged commit 55a61e4 into grpc:master Apr 7, 2017

12 of 16 checks passed

Basic Tests Linux Build finished.
Details
Basic Tests Mac Build finished.
Details
Bazel Full Build & Tests Build finished.
Details
gRPC_interop_pull_requests Build finished.
Details
Asan C Build finished.
Details
Asan C++ Build finished.
Details
Basic Tests Windows Build finished.
Details
Bazel Basic Build Build finished.
Details
Msan C Build finished.
Details
Portability Tests Linux Build finished.
Details
Portability Tests Windows Build finished.
Details
Sanity Tests (internal CI, ignore for now) Kokoro build finished
Details
Tsan C Build finished.
Details
Tsan C++ Build finished.
Details
cla/google All necessary CLAs are signed
gRPC_performance_pull_requests Build finished.
Details

@ncteisen ncteisen deleted the ncteisen:error-overflow branch Apr 7, 2017

@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.