Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly installed shared library version #10923

Closed
wants to merge 1 commit into from

Conversation

Shizmob
Copy link

@Shizmob Shizmob commented Apr 29, 2017

This fixes a mismatch between the SONAME in the C++ and C# libraries and the
actually installed shared library name: in the former case it uses the
language-specific major version, and in the latter case it uses the core major
major version. Switch to using the language-specific major version in the
installed shared library name as well to fix this mismatch.

This fixes a mismatch between the SONAME in the C++ and C# libraries and the
actually installed shared library name: in the former case it uses the
language-specific major version, and in the latter case it uses the core major
major version. Switch to using the language-specific major version in the
installed shared library name as well to fix this mismatch.
@googlebot
Copy link

googlebot commented Apr 29, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ctiller
Copy link
Member

ctiller commented Apr 29, 2017

Jenkins: this is ok to test

@Shizmob
Copy link
Author

Shizmob commented Apr 29, 2017

CLA signed.

@googlebot
Copy link

googlebot commented Apr 29, 2017

CLAs look good, thanks!

@grpc-testing
Copy link

grpc-testing commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

14 similar comments
@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-testing
Copy link

grpc-testing commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Apr 29, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@Shizmob
Copy link
Author

Shizmob commented Apr 29, 2017

🤔

@grpc-testing
Copy link

grpc-testing commented Apr 29, 2017

No significant performance differences

@grpc-kokoro
Copy link

grpc-kokoro commented May 4, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

3 similar comments
@grpc-kokoro
Copy link

grpc-kokoro commented May 16, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-testing
Copy link

grpc-testing commented Jul 17, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-testing
Copy link

grpc-testing commented Jul 17, 2017

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

grpc-kokoro commented Jul 17, 2017

[trickle] No significant performance differences

@jtattermusch
Copy link
Contributor

jtattermusch commented Nov 16, 2018

Closing as duplicate of #16832.

@thelinuxfoundation
Copy link

thelinuxfoundation commented Nov 16, 2018

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@jtattermusch jtattermusch self-assigned this Nov 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants