Base the ruby artifact-build docker file off of rake-compiler-dock's #13910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
apolcyn
changed the title
|
|
|
|
|
|
|
I'm going to rebase this to be off of master instead of 1.8.x |
apolcyn
requested review from
ctiller,
dgquintas,
markdroth and
nicolasnoble
as code owners
|
|
|
dgquintas
reviewed
Jan 5, 2018
Yeah this third-party directory is our own code, it's a kind of fork of https://github.com/rake-compiler/rake-compiler-dock that lives in our repo |
|
|
|
nicolasnoble
reviewed
Jan 9, 2018
| @@ -113,10 +113,10 @@ task 'gem:native' do | |||
| if RUBY_PLATFORM =~ /darwin/ | |||
| FileUtils.touch 'grpc_c.32.ruby' | |||
| FileUtils.touch 'grpc_c.64.ruby' | |||
| system "rake cross native gem RUBY_CC_VERSION=2.4.0:2.3.0:2.2.2:2.1.5:2.0.0 V=#{verbose} GRPC_CONFIG=#{grpc_config}" | |||
| system "rake cross native gem RUBY_CC_VERSION=2.5.0:2.4.0:2.3.0:2.2.2:2.1.6:2.0.0 V=#{verbose} GRPC_CONFIG=#{grpc_config}" | |||
There was a problem hiding this comment.
Did you change our set of Darwin environments as well ? As in, I'm not sure you want to move from 2.1.5 to 2.1.6 on Darwin, do you ?
There was a problem hiding this comment.
Darwin environments were changed in earlier PR: https://github.com/grpc/grpc/pull/13930/files. I didn't see adjusting the Darwin 2.1.x to use 2.1.6 as strictly necessary, I just did that only for consistency (as I understand 2.1.6 is ABI-compatible with 2.1.5).
There was a problem hiding this comment.
FTR manual smoke testing seems fine (grpc built against ruby-2.1.6 still loads fine on ruby 2.1.0). I'm fairly confident that building against 2.1.6 is non-breaking too since, e.g., up through now I believe that any ABI incompatibilities between ruby teeny version releases would break the grpc package (https://github.com/grpc/grpc/blame/master/src/ruby/lib/grpc/grpc.rb#L16)
nicolasnoble
approved these changes
Jan 9, 2018
|
basic tests c++ linux opt: #13429 thanks for the looks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful artifact build in https://grpc-testing.appspot.com/job/gRPC_build_artifacts/1612/ and https://grpc-testing.appspot.com/job/gRPC_build_artifacts/1613/
It looks like some of grpc's fork's changes landed upstream after rake-compiler/rake-compiler-dock#13
Towards fixing #13908 (this adds ruby-2.5 to the linux and windows builds).
Manually tested that the packages built off https://grpc-testing.appspot.com/job/gRPC_build_artifacts/1613/ load OK on
Distrib tests are green: https://grpc-testing.appspot.com/job/gRPC_distribtest/1593/#showFailuresLink
PTAL I think this is ready