Bazel rules for gRPC Python interop tests #16813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielmanistaatgoogle
added
lang/Python
priority/P2
infra/Bazel
release notes: no
|
|
|
|
ghostwriternr
force-pushed
the
bazel-python-interop-tests
branch
2 times, most recently
from
acfa7c5
to
a7c4b57
Compare
|
|
|
|
nathanielmanistaatgoogle
approved these changes
Oct 9, 2018
|
|
|
|
|
|
|
Restarted the tests as interop test was broken yesterday due to some other reason. |
|
|
|
|
mehrdada
reviewed
Oct 10, 2018
src/proto/grpc/testing/BUILD
Outdated
| ] | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
Are these newlines produced by a formatting tool? If not, let's get rid of extra newlines.
There was a problem hiding this comment.
Ah, no. Just my editor! I believe it is a standard convention to have one newline at the end of a Python file (which Skylark essentially is a stripped down version of). I've updated my commit to reflect that now.
There was a problem hiding this comment.
Something to be done at a later time in a later pull request: Bazel has a tool called "buildifier", and whatever buildifier says is the way a BUILD file should be formatted is the way it should be formatted. 🙂
@nicolasnoble: is now or the near future about the right time to add buildifier to the sanity tests?
Add interop tests for gRPC Python. py_proto_library rules are added to src/proto/grpc/testing/BUILD since grpc_proto_library is not compatible with py_* rules. 'requests' python module is added to requirements.bazel.txt as it is a dependency for google-auth. Previously, this was installed through tools/run_tests/helper_scripts/build_python.sh before running tests.
ghostwriternr
force-pushed
the
bazel-python-interop-tests
branch
from
a7c4b57
to
9172775
Compare
|
|
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add interop tests for gRPC Python. py_proto_library rules are added to src/proto/grpc/testing/BUILD since grpc_proto_library is not compatible with py_* rules.
'requests' python module is added to requirements.bazel.txt as it is a dependency for google-auth. Previously, this was installed through tools/run_tests/helper_scripts/build_python.sh before running tests.