From f46bd7f80d88b295b48f26f4c3264bde20e04d1c Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Tue, 1 Dec 2020 17:29:33 +0100 Subject: [PATCH 1/3] stop building protoc x86 artifacts on macos --- src/csharp/Grpc.Tools/Grpc.Tools.csproj | 2 -- tools/run_tests/artifacts/artifact_targets.py | 1 - 2 files changed, 3 deletions(-) diff --git a/src/csharp/Grpc.Tools/Grpc.Tools.csproj b/src/csharp/Grpc.Tools/Grpc.Tools.csproj index 3923a8c5510b2..752d8651bbbb2 100644 --- a/src/csharp/Grpc.Tools/Grpc.Tools.csproj +++ b/src/csharp/Grpc.Tools/Grpc.Tools.csproj @@ -62,7 +62,6 @@ Linux and MacOS. Managed runtime is supplied separately in the Grpc.Core package <_Asset PackagePath="tools/windows_x64/" Include="$(Assets_ProtoCompiler)windows_x64/protoc.exe" /> <_Asset PackagePath="tools/linux_x86/" Include="$(Assets_ProtoCompiler)linux_x86/protoc" /> <_Asset PackagePath="tools/linux_x64/" Include="$(Assets_ProtoCompiler)linux_x64/protoc" /> - <_Asset PackagePath="tools/macosx_x86/" Include="$(Assets_ProtoCompiler)macos_x86/protoc" /> <_Asset PackagePath="tools/macosx_x64/" Include="$(Assets_ProtoCompiler)macos_x64/protoc" /> @@ -70,7 +69,6 @@ Linux and MacOS. Managed runtime is supplied separately in the Grpc.Core package <_Asset PackagePath="tools/windows_x64/" Include="$(Assets_GrpcPlugins)protoc_windows_x64/grpc_csharp_plugin.exe" /> <_Asset PackagePath="tools/linux_x86/" Include="$(Assets_GrpcPlugins)protoc_linux_x86/grpc_csharp_plugin" /> <_Asset PackagePath="tools/linux_x64/" Include="$(Assets_GrpcPlugins)protoc_linux_x64/grpc_csharp_plugin" /> - <_Asset PackagePath="tools/macosx_x86/" Include="$(Assets_GrpcPlugins)protoc_macos_x86/grpc_csharp_plugin" /> <_Asset PackagePath="tools/macosx_x64/" Include="$(Assets_GrpcPlugins)protoc_macos_x64/grpc_csharp_plugin" /> diff --git a/tools/run_tests/artifacts/artifact_targets.py b/tools/run_tests/artifacts/artifact_targets.py index fbbfcc80d9312..c2cea29f069db 100644 --- a/tools/run_tests/artifacts/artifact_targets.py +++ b/tools/run_tests/artifacts/artifact_targets.py @@ -348,7 +348,6 @@ def targets(): ProtocArtifact('linux', 'x64'), ProtocArtifact('linux', 'x86'), ProtocArtifact('macos', 'x64'), - ProtocArtifact('macos', 'x86'), ProtocArtifact('windows', 'x64'), ProtocArtifact('windows', 'x86'), CSharpExtArtifact('linux', 'x64'), From 94ccbef5eae265192ce6b44be1090c2dc8638256 Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Wed, 2 Dec 2020 15:35:23 +0100 Subject: [PATCH 2/3] skip packaging macos x86 protoc in grpc-tools gem --- tools/run_tests/artifacts/build_package_ruby.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/run_tests/artifacts/build_package_ruby.sh b/tools/run_tests/artifacts/build_package_ruby.sh index bd62ec1ff469c..bd54c02e45581 100755 --- a/tools/run_tests/artifacts/build_package_ruby.sh +++ b/tools/run_tests/artifacts/build_package_ruby.sh @@ -41,6 +41,11 @@ for arch in {x86,x64}; do ;; esac for plat in {windows,linux,macos}; do + # skip non-existent macos x86 protoc artifact + if [[ "${plat}_${arch}" == "macos_x86"]] + then + continue + fi input_dir="${EXTERNAL_GIT_ROOT}/input_artifacts/protoc_${plat}_${arch}" output_dir="$base/src/ruby/tools/bin/${ruby_arch}-${plat}" mkdir -p "$output_dir"/google/protobuf From db521f52f9b70afdb04d6e22cb26c98ec193b40e Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Wed, 2 Dec 2020 16:12:43 +0100 Subject: [PATCH 3/3] fixup shellcheck problem --- tools/run_tests/artifacts/build_package_ruby.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/run_tests/artifacts/build_package_ruby.sh b/tools/run_tests/artifacts/build_package_ruby.sh index bd54c02e45581..14faab4b95e41 100755 --- a/tools/run_tests/artifacts/build_package_ruby.sh +++ b/tools/run_tests/artifacts/build_package_ruby.sh @@ -42,7 +42,7 @@ for arch in {x86,x64}; do esac for plat in {windows,linux,macos}; do # skip non-existent macos x86 protoc artifact - if [[ "${plat}_${arch}" == "macos_x86"]] + if [[ "${plat}_${arch}" == "macos_x86" ]] then continue fi