New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client side response path crash, expand corpora #6202

Merged
merged 3 commits into from Apr 18, 2016
Jump to file or symbol
Failed to load files and symbols.
+1,057 −154
Diff settings

Always

Just for now

Viewing a subset of changes. View all
Prev

Expand corpus, fix crash

  • Loading branch information...
ctiller committed Apr 18, 2016
commit 2e3e0039b30edaf89fb93bfb2c1d0909098519fa
@@ -638,6 +638,10 @@ static int on_hdr(grpc_chttp2_hpack_parser *p, grpc_mdelem *md,
return 0;
}
}
if (p->on_header == NULL) {
grpc_mdelem_unref(md);
return 0;
}
p->on_header(p->on_header_user_data, md);
return 1;
}
@@ -1382,12 +1386,8 @@ static int parse_value_string_with_literal_key(grpc_chttp2_hpack_parser *p,
/* PUBLIC INTERFACE */
static void on_header_not_set(void *user_data, grpc_mdelem *md) {
GPR_UNREACHABLE_CODE(return );
}
void grpc_chttp2_hpack_parser_init(grpc_chttp2_hpack_parser *p) {
p->on_header = on_header_not_set;
p->on_header = NULL;
p->on_header_user_data = NULL;
p->state = parse_begin;
p->key.str = NULL;
@@ -1455,7 +1455,7 @@ grpc_chttp2_parse_error grpc_chttp2_header_parser_parse(
stream_parsing->received_close = 1;
}
}
parser->on_header = on_header_not_set;
parser->on_header = NULL;
parser->on_header_user_data = NULL;
parser->is_boundary = 0xde;
parser->is_eof = 0xde;
@@ -0,0 +1 @@
!m��!��������
Oops, something went wrong.