New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load default roots.pem in PHP via grpc_set_ssl_roots_override_callback #6848

Merged
merged 1 commit into from Jun 20, 2016

Conversation

Projects
None yet
6 participants
@thinkerou
Copy link
Contributor

thinkerou commented Jun 9, 2016

Attempts to fixs this #5711.

@googlebot googlebot added the cla: yes label Jun 9, 2016

@grpc-kokoro

This comment has been minimized.

Copy link

grpc-kokoro commented Jun 9, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

3 similar comments
@grpc-kokoro

This comment has been minimized.

Copy link

grpc-kokoro commented Jun 9, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@grpc-kokoro

This comment has been minimized.

Copy link

grpc-kokoro commented Jun 9, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@grpc-kokoro

This comment has been minimized.

Copy link

grpc-kokoro commented Jun 9, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@murgatroid99

This comment has been minimized.

Copy link
Member

murgatroid99 commented Jun 9, 2016

Can you please send this PR without all of the irrelevant commits? All of the changes for this PR are in the second-to-last commit.

@grpc-kokoro

This comment has been minimized.

Copy link

grpc-kokoro commented Jun 16, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@thinkerou thinkerou force-pushed the thinkerou:default_roots_pem branch from 1e60d3d to f3bc3b6 Jun 17, 2016

@thinkerou

This comment has been minimized.

Copy link
Contributor Author

thinkerou commented Jun 17, 2016

@murgatroid99 I have cleaned up all of the extra commits.

@stanley-cheung

This comment has been minimized.

Copy link
Contributor

stanley-cheung commented Jun 17, 2016

LGTM @murgatroid99 is the user of gpr_malloc appropriate here?

@murgatroid99

This comment has been minimized.

Copy link
Member

murgatroid99 commented Jun 17, 2016

I think so. This change is copied pretty much verbatim from the corresponding Node change.

@jtattermusch jtattermusch merged commit 1468d4b into grpc:master Jun 20, 2016

5 of 6 checks passed

Basic tests Build finished.
Details
Interop tests Build finished.
Details
Peformance smoke test Build finished.
Details
Portability tests Build finished.
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.