New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GRPC_NEED_UDP define #6932

Closed
wants to merge 15 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@thinkerou
Copy link
Contributor

thinkerou commented Jun 16, 2016

Attempt to fix #5748 and #6624.
The commit have defined GRPC_NEED_UDP in c file, see:
2908a76

@googlebot googlebot added the cla: yes label Jun 16, 2016

@grpc-kokoro

This comment has been minimized.

Copy link

grpc-kokoro commented Jun 16, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

3 similar comments
@grpc-kokoro

This comment has been minimized.

Copy link

grpc-kokoro commented Jun 16, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@grpc-kokoro

This comment has been minimized.

Copy link

grpc-kokoro commented Jun 16, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@grpc-kokoro

This comment has been minimized.

Copy link

grpc-kokoro commented Jun 16, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@ctiller

This comment has been minimized.

Copy link
Member

ctiller commented Jun 16, 2016

I'm not sure we want this to be blanket turned on for all platforms.

Also, it'd be good to clean up some of the spurious unrelated commits here.

@thinkerou

This comment has been minimized.

Copy link
Contributor Author

thinkerou commented Jun 16, 2016

@ctiller I got it, I will close it. I should learn how clean up all of the extra commits before commit PR, thx.

@thinkerou thinkerou closed this Jun 17, 2016

@thinkerou thinkerou deleted the thinkerou:add_udp_define branch Jun 17, 2016

@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.