From 0242b0edc90e773d4ceb0745ec1744a0d908be99 Mon Sep 17 00:00:00 2001 From: Yousuk Seung Date: Wed, 17 Apr 2024 14:02:41 -0700 Subject: [PATCH 1/4] L115: Refactor generic service and generic stub --- L115-core-refactor-generic-service-stub.md | 42 ++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 L115-core-refactor-generic-service-stub.md diff --git a/L115-core-refactor-generic-service-stub.md b/L115-core-refactor-generic-service-stub.md new file mode 100644 index 000000000..26aa03eac --- /dev/null +++ b/L115-core-refactor-generic-service-stub.md @@ -0,0 +1,42 @@ +L115: C-Core Refactor generic service and generic stub +---- +* Author(s): ysseung +* Approver: ctiller +* Status: Draft +* Implemented in: C Core +* Last updated: 2024/04/15 +* Discussion at: https://groups.google.com/g/grpc-io/c/TBA + +## Abstract + +We will refactor `async_generic_service.h` and `generic_stub.h` to move +callback based interfaces into separate targets. Existing files will include +the callback based interfaces. + +## Background + +This enables services to only depend on the callback based interfaces of the +generic stub and generic service. + +### Related Proposals: + +None. + +## Proposal + +We will move `CallbackGenericService` in `async_generic_service.h` to a new file +`async_generic_service_callback.h` and make it a new public target +`:generic_service_callback`. `async_generic_service.h` will include +`async_generic_service_callback.h` and existing dependencies will continue to +include both. + +We will also move move callback based interfaces of `TemplatedGenericStub` in +`generic_stub.h` to a new class `TemplatedGenericStubCallback` in +`generic_stub_callback.h` and make it a new public target +`:generic_stub_callback`. `CallbackGenericService` will inherit +`CallbackGenericServiceCallback` and existing dependencies will continue to +include both. + +## Implementation + +TBA From 6b21e6222e5c2b5f251bb53165778ab461c58190 Mon Sep 17 00:00:00 2001 From: Yousuk Seung Date: Thu, 18 Apr 2024 13:31:15 -0700 Subject: [PATCH 2/4] discussion link added --- L115-core-refactor-generic-service-stub.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/L115-core-refactor-generic-service-stub.md b/L115-core-refactor-generic-service-stub.md index 26aa03eac..6aa1735a6 100644 --- a/L115-core-refactor-generic-service-stub.md +++ b/L115-core-refactor-generic-service-stub.md @@ -5,7 +5,7 @@ L115: C-Core Refactor generic service and generic stub * Status: Draft * Implemented in: C Core * Last updated: 2024/04/15 -* Discussion at: https://groups.google.com/g/grpc-io/c/TBA +* Discussion at: https://groups.google.com/g/grpc-io/c/301w3zXYf8o ## Abstract @@ -18,7 +18,7 @@ the callback based interfaces. This enables services to only depend on the callback based interfaces of the generic stub and generic service. -### Related Proposals: +### Related Proposals None. From 5cf4bceaafb5dbe180653a44dc44bf07dbfa86eb Mon Sep 17 00:00:00 2001 From: Yousuk Seung Date: Thu, 18 Apr 2024 14:37:28 -0700 Subject: [PATCH 3/4] rename --- L115-core-refactor-generic-service-stub.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/L115-core-refactor-generic-service-stub.md b/L115-core-refactor-generic-service-stub.md index 6aa1735a6..42d0106e4 100644 --- a/L115-core-refactor-generic-service-stub.md +++ b/L115-core-refactor-generic-service-stub.md @@ -25,16 +25,16 @@ None. ## Proposal We will move `CallbackGenericService` in `async_generic_service.h` to a new file -`async_generic_service_callback.h` and make it a new public target -`:generic_service_callback`. `async_generic_service.h` will include -`async_generic_service_callback.h` and existing dependencies will continue to +`callback_generic_service.h` and make it a new public target +`:callback_generic_service`. `async_generic_service.h` will include +`callback_generic_service.h` and existing dependencies will continue to include both. We will also move move callback based interfaces of `TemplatedGenericStub` in `generic_stub.h` to a new class `TemplatedGenericStubCallback` in `generic_stub_callback.h` and make it a new public target `:generic_stub_callback`. `CallbackGenericService` will inherit -`CallbackGenericServiceCallback` and existing dependencies will continue to +`CallbackGenericService` and existing dependencies will continue to include both. ## Implementation From f71c7a070800d423116f09ea00ff992f9c93e201 Mon Sep 17 00:00:00 2001 From: Yousuk Seung Date: Thu, 25 Apr 2024 14:39:29 -0700 Subject: [PATCH 4/4] Added a link to PR --- L115-core-refactor-generic-service-stub.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/L115-core-refactor-generic-service-stub.md b/L115-core-refactor-generic-service-stub.md index 42d0106e4..c5816f0a3 100644 --- a/L115-core-refactor-generic-service-stub.md +++ b/L115-core-refactor-generic-service-stub.md @@ -39,4 +39,4 @@ include both. ## Implementation -TBA +https://github.com/grpc/grpc/pull/36447