Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Bar Enhancer broken on mozilla-central since 2016-11-22 #155

Open
mzso opened this issue Nov 23, 2016 · 10 comments

Comments

@mzso
Copy link

commented Nov 23, 2016

Hi!

It's just completely dead. Maybe this is the culprit: https://bugzilla.mozilla.org/show_bug.cgi?id=1293305

@grssam

This comment has been minimized.

Copy link
Owner

commented Nov 23, 2016

Yes it is. I'll fix this and another one of my affected addon in couple of
days. Please go ahead if you are on the fix yourself! :)

On Thu, Nov 24, 2016 at 1:39 AM, mzso notifications@github.com wrote:

Hi!

It's just completely dead. Maybe this is the culprit:
https://bugzilla.mozilla.org/show_bug.cgi?id=1293305


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#155, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAj-fCRcqbFOf28wYNvDdpok7cy8OALVks5rBJ2VgaJpZM4K7AH5
.

Girish Sharma
B.Tech(H), Civil Engineering,
Indian Institute of Technology, Kharagpur

@mzso

This comment has been minimized.

Copy link
Author

commented Nov 23, 2016

@grssam commented on 2016. nov. 23. 21:15 CET:

Yes it is. I'll fix this and another one of my affected addon in couple of days. Please go ahead if you are on the fix yourself! :)

Sorry. No competence. But I'll certainly keep watching this issue.

@mzso

This comment has been minimized.

Copy link
Author

commented Dec 1, 2016

Now that Flashgot and Session Manager updated, it looks like this is the only addon I have that remains broken. Is there a fix on the horizon?

@mzso

This comment has been minimized.

Copy link
Author

commented Dec 2, 2016

I did a mozregression test and it pointed to: https://bugzilla.mozilla.org/show_bug.cgi?id=1317947
Which doesn't really seem to be related.

Note to self: Never use mozregression!

@mzso

This comment has been minimized.

Copy link
Author

commented Dec 18, 2016

After realizing that "for each" is used twice, and following a suggestion to fix it, I tinkered a working version.

Here it is, if anyone wants to use it until a real fix is made:
location_bar_enhancer-5.3-fx-MOD2.zip

@tumpio

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2016

@mzso If you know how to use git, submit your changes as a pull request. This way Girish can merge the patch and release a fixed version for everyone.

@mzso

This comment has been minimized.

Copy link
Author

commented Dec 18, 2016

@tumpio commented on 2016. dec. 18. 23:28 CET:

@mzso If you know how to use git, submit your changes as a pull request. This way Girish can merge the patch and release a fixed version for everyone.

Sorry I'm not familiar with git. (Or software development.) Anyway, I only changed two lines in helper.js as per the suggestions of this post.

@tumpio

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2016

@mzso GitHub also provides web interface for it. It is very easy to use. Browse to the file you want to edit in the "code" tab.

Click the pen/edit button. Do the edit, add some description what you did and then "Propose the file change". After that I think you can do the pull request or it does it automatically. I encourage you to try it out. 👍

@mzso

This comment has been minimized.

Copy link
Author

commented Dec 19, 2016

@tumpio commented on 2016. dec. 19. 09:37 CET:

@mzso GitHub also provides web interface for it. It is very easy to use. Browse to the file you want to edit in the "code" tab.

Click the pen/edit button. Do the edit, add some description what you did and then "Propose the file change". After that I think you can do the pull request or it does it automatically. I encourage you to try it out. 👍

Well, I did it.

(Meanwhile I noticed that Mozilla broke dropping text into the urlbar on nightly...)

@mzso

This comment has been minimized.

Copy link
Author

commented Jan 28, 2017

@mzso commented on 2016. dec. 19. 12:14 CET:

(Meanwhile I noticed that Mozilla broke dropping text into the urlbar on nightly...)

Well, they fixed that issue in https://bugzilla.mozilla.org/show_bug.cgi?id=1324410
It turns out it works better now than before with LBE (if you have the fore-each fix of-course). :) Now it works if you drop text on the breadcrumbs, you don't have to find an empty area on the urlbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.