-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location Bar Enhancer broken on mozilla-central since 2016-11-22 #155
Comments
Yes it is. I'll fix this and another one of my affected addon in couple of On Thu, Nov 24, 2016 at 1:39 AM, mzso notifications@github.com wrote:
Girish Sharma |
@grssam commented on 2016. nov. 23. 21:15 CET:
Sorry. No competence. But I'll certainly keep watching this issue. |
Now that Flashgot and Session Manager updated, it looks like this is the only addon I have that remains broken. Is there a fix on the horizon? |
Note to self: Never use mozregression! |
After realizing that "for each" is used twice, and following a suggestion to fix it, I tinkered a working version. Here it is, if anyone wants to use it until a real fix is made: |
@mzso If you know how to use git, submit your changes as a pull request. This way Girish can merge the patch and release a fixed version for everyone. |
@tumpio commented on 2016. dec. 18. 23:28 CET:
Sorry I'm not familiar with git. (Or software development.) Anyway, I only changed two lines in helper.js as per the suggestions of this post. |
@mzso GitHub also provides web interface for it. It is very easy to use. Browse to the file you want to edit in the "code" tab. Click the pen/edit button. Do the edit, add some description what you did and then "Propose the file change". After that I think you can do the pull request or it does it automatically. I encourage you to try it out. 👍 |
@tumpio commented on 2016. dec. 19. 09:37 CET:
Well, I did it. (Meanwhile I noticed that Mozilla broke dropping text into the urlbar on nightly...) |
@mzso commented on 2016. dec. 19. 12:14 CET:
Well, they fixed that issue in https://bugzilla.mozilla.org/show_bug.cgi?id=1324410 |
Hi!
It's just completely dead. Maybe this is the culprit: https://bugzilla.mozilla.org/show_bug.cgi?id=1293305
The text was updated successfully, but these errors were encountered: