New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split qrcode-reader in 3 different components #73

Merged
merged 6 commits into from Oct 29, 2018

Conversation

Projects
None yet
1 participant
@gruhn
Owner

gruhn commented Oct 24, 2018

Introducing a dedicated component for classic file upload/media capture.

Import independently from main component:

import { QrcodeReader, QrcodeCapture } from 'vue-qrcode-reader'

The component emits decode and detect exactly like the main component:

<qrcode-capture @decode="..." @detect="..." />

The component renders to a simple input element:

<input
    type="file"
    name="image"
    accept="image/*"
    capture="environment"
    multiple>

gruhn added some commits Oct 23, 2018

feat: fallback for old mobile devices
Create dedicated component based on HTML Media Capture. Instead
of continiously scanning a camera stream, mobile devices can take
a single picture to be uploaded. Also allows classic file upload
which can also serve desktop devices.

See #63 #56
feat: expose QrcodeDropZone component
Expose dedicated component to read drag-and-dropped images/urls.
refactor: rename QrcodeReader to QrcodeStream
Since the project now exposes multiple components, it's worth
distinguishing between the name of the project and the name of the
components. QrcodeReader now refers to the project, while
QrcodeStream refers to the component which detects and decodes
qrcodes from a camera stream.

In contrast to QrcodeReader, QrcodeStream does not expose the
deprecated `video-constraints` prop anymore and also does not
detect drag-and-dropped images/urls anymore (this feature can be
easily re-added by wrapping QrcodeStream with QrcodeDropZone).

@gruhn gruhn force-pushed the feature/qrcode-capture branch from ce4603f to c58cd01 Oct 29, 2018

@gruhn gruhn changed the title from Decode QR codes via file upload to Split qrcode-reader in 3 different components Oct 29, 2018

@gruhn gruhn force-pushed the feature/qrcode-capture branch from c58cd01 to 900e2a8 Oct 29, 2018

@gruhn gruhn merged commit 932d652 into master Oct 29, 2018

@gruhn

This comment has been minimized.

Owner

gruhn commented Oct 29, 2018

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gruhn gruhn deleted the feature/qrcode-capture branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment