Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Enhancements to `options.middleware` #85
I'm the author of a developer utility called json-proxy and love grunt! I noticed recently my documentation for injecting json-proxy as middleware into grunt-contrib-connect no longer worked properly with Yeoman.io templates.
I realized that users are copying the default middlewares function from connect.js#L31-45.
This seems really fragile, and awkward for users. See drewzboto/grunt-connect-proxy#29 as an example.
So, I enhanced the
I included passing nodeunit tests and updated the relevant docs. I also refactored the tests to include coverage for HTTPS use cases (which I believe other PRs may address as well; figured it was worth fixing while I was in the codebase). Finally, I reconfigured the test cases to use a sequential set of ports starting at TCP port 8000.
Hi @vladikoff, just pushed a squashed commit. I prefer squashed commits too, but, wasn't sure if that was kosher since I had pushed my commits to origin. Thinking about it now, it makes sense that squashing and force pushing to my fork wouldn't harm the mainline repo. Learn something new everyday!