Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add command line option to specify the working directory for the formatters #10

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

4kochi commented Mar 28, 2013

The formatters from csslint use relative file names in the generated reports. In some cases the tools which consume theses reports need absolute file names (i.e. Violations Plugin in Jenkins). So now you can set the command line option --workspace to specify the working directory. In result the file names in the reports will be then absolute (workspace + relative file name)

4kochi added some commits Mar 12, 2013

@4kochi 4kochi Add templates
update .gitignore
b703230
@4kochi 4kochi Add logic for writing csslint results to junit and checkstyle xml file 5c32396
@4kochi 4kochi Add logic for writing csslint results to junit and checkstyle xml file 8bf53ff
@4kochi 4kochi Update readme 81ad9b7
@4kochi 4kochi Update .gitignore
Update Gruntfile
5efa563
@4kochi 4kochi Merge branch 'remote'
* remote:
  Fixed erroneous comment about JSHint.
  quote version number for travis
  add node 0.10 to travis
  version bump / author addition
  Added ability to use csslint formatters for outputting results in various file formats
  Support loading rules from an external .csslintrc file
bba248c
@4kochi 4kochi update gitignore 6584d06
@4kochi 4kochi Add option to set a working directory for the reports 5f5a013
@4kochi 4kochi Update readme 0c2fa8f
@4kochi 4kochi Update readme 695e039
@4kochi 4kochi Rename workDir in workspace cedc0fa
Owner

tkellen commented Mar 29, 2013

Andreas--

Thanks for taking the time to put this PR together! Controlling options with grunt is typically performed in the task configuration, not via the CLI . If we implement this, it should be an option. Also, you can get the absolute path to a file using path.resolve(). Finally, I'm not familiar with these xml reports, but isn't there integration provided for this within csslint itself? @jzaefferer could you chime in here?

Contributor

4kochi commented Mar 29, 2013

Thanks for the hint with path.resolve. I will try this. I already use the reports directly from csslint, but there is no way to configure them right now in the plugin, threfore the PR.

Contributor

4kochi commented Mar 30, 2013

I have implemented path.resolve() and it works fine. So i dont't need the command line param any more. I will close this Pull Request and will make a new one. There are too much changes in the current PR so a clean start is better.

@4kochi 4kochi closed this Mar 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment