phantomjs options passing #82

Closed
jakerella opened this Issue Sep 10, 2013 · 2 comments

Projects

None yet

2 participants

@jakerella

It looks like the task file, on line 98, passes the entire options object into phantomjs, but it looks like, based on line 40 that it should be options.phantomjs. I haven't made this change in my code (or submitted a PR) because this could break for people using the options object directly.

I guess I'm just looking for feedback on whether the options object was intended to work that way or what. Thanks!

@jsoverson
grunt member

The options are expected to be at the root level, that was a change at some point with the phantomjs lib and the original initialization of that object wasn't removed. Feel free to do a PR, thanks!

@jakerella

Coolio, Wasn't sure which direction the code was going! ;)

@jakerella jakerella added a commit to jakerella/grunt-contrib-jasmine that referenced this issue Sep 10, 2013
@jakerella jakerella Removed unused 'phantomjs' options object from task per issue #82 in …
…main repo.
9af3f8a
@jsoverson jsoverson closed this Sep 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment