Skip to content
This repository

phantomjs options passing #82

jakerella opened this Issue September 10, 2013 · 2 comments

2 participants

Jordan Kasper Jarrod Overson
Jordan Kasper

It looks like the task file, on line 98, passes the entire options object into phantomjs, but it looks like, based on line 40 that it should be options.phantomjs. I haven't made this change in my code (or submitted a PR) because this could break for people using the options object directly.

I guess I'm just looking for feedback on whether the options object was intended to work that way or what. Thanks!

Jarrod Overson

The options are expected to be at the root level, that was a change at some point with the phantomjs lib and the original initialization of that object wasn't removed. Feel free to do a PR, thanks!

Jordan Kasper

Coolio, Wasn't sure which direction the code was going! ;)

Jordan Kasper jakerella referenced this issue from a commit in jakerella/grunt-contrib-jasmine September 10, 2013
Jordan Kasper Removed unused 'phantomjs' options object from task per issue #82 in …
…main repo.
Jarrod Overson jsoverson closed this September 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.