Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Do not expand pattern before passing to Gaze. #43

Closed
wants to merge 1 commit into from

2 participants

@itsjamie

This would fix GH-20, however, the referenced pull-request should finish before merging this change.

@itsjamie itsjamie commented on the diff
tasks/watch.js
@@ -101,14 +101,11 @@ module.exports = function(grunt) {
if (typeof target.files === 'string') {
target.files = [target.files];
}
- // Get patterns to glob for this target
- var patterns = grunt.file.expand(target.files);

This caused an issue because the original glob patterns didn't make it to Gaze, instead we had an array of patterns that matched individual files, therefore, new files would never match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@itsjamie itsjamie referenced this pull request in shama/gaze
Closed

Adds Exclusion Support to Gaze. Fixes GH-7 #21

@shama
Owner

Will merge this as soon as the upstream changes come in. Thanks!

@shama shama closed this in f857f2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 31, 2013
  1. @itsjamie
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 4 deletions.
  1. +1 −4 tasks/watch.js
View
5 tasks/watch.js
@@ -101,14 +101,11 @@ module.exports = function(grunt) {
if (typeof target.files === 'string') {
target.files = [target.files];
}
- // Get patterns to glob for this target
- var patterns = grunt.file.expand(target.files);

This caused an issue because the original glob patterns didn't make it to Gaze, instead we had an array of patterns that matched individual files, therefore, new files would never match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
-
// Default options per target
var options = grunt.util._.defaults(target.options || {}, defaults);
// Create watcher per target
- var gaze = new Gaze(patterns, options, function(err) {
+ var gaze = new Gaze(target.files, options, function(err) {
if (err) {
grunt.log.error(err.message);
return done();
Something went wrong with that request. Please try again.