Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SOURCE_DATE_EPOCH to render dates in template. #1596

Merged
merged 1 commit into from Aug 25, 2018

Conversation

lamby
Copy link
Contributor

@lamby lamby commented Jul 9, 2017

Whilst working on the Reproducible Builds effort [0], we noticed
that grunt can generate non-reproducible output. This is affecting the
reproducibility status other packages (such as jquery-tablesorter) that
set a "pkg.banner" such as:

<%= grunt.template.today("mm-dd-yyyy")

[0] https://reproducible-builds.org/

Signed-off-by: Chris Lamb chris@chris-lamb.co.uk

@jsf-clabot
Copy link

jsf-clabot commented Jul 9, 2017

CLA assistant check
All committers have signed the CLA.

@lamby
Copy link
Contributor Author

lamby commented Sep 14, 2017

Any update on this? It's also affecting packages like searx now. :)

@lamby
Copy link
Contributor Author

lamby commented Aug 25, 2018

Gentle ping on this 2017 PR? :)

@vladikoff
Copy link
Member

@lamby sorry, first time i see this, could you please rebase this PR?

Whilst working on the Reproducible Builds effort [0], we noticed
that grunt can generate non-reproducible output. This is affecting the
reproducibility status other packages (such as jquery-tablesorter) that
set a "pkg.banner" such as:

   <%= grunt.template.today("mm-dd-yyyy")

 [0] https://reproducible-builds.org/

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
@lamby
Copy link
Contributor Author

lamby commented Aug 25, 2018

@vladikoff Done.

@vladikoff vladikoff merged commit 7db6cf7 into gruntjs:master Aug 25, 2018
@lamby lamby deleted the source-date-epoch branch August 26, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants