Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use `safeLoad` for loading YML files via `file.readYAML`. #1719

Merged
merged 1 commit into from Aug 18, 2020

Conversation

@vladikoff
Copy link
Member

@vladikoff vladikoff commented Aug 17, 2020

For previous behaviour please use the following:

readYAML('test/fixtures/utf8.yaml', null, {unsafeLoad: true});

@shama got a sec for an r? 馃憖

For previous behaviour please use the following:

```
readYAML('test/fixtures/utf8.yaml', null, {unsafeLoad: true});
```
@vladikoff vladikoff requested a review from shama Aug 17, 2020
@shama
Copy link
Member

@shama shama commented Aug 18, 2020

Seems 馃憤 to me. I guess if someone is relying on it loading unsafely by default their build will break with this change. IMO is a good thing because if they're relying on an unsafe API they should be explicit about it. My 2 cents.

@vladikoff vladikoff merged commit 7e669ac into master Aug 18, 2020
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@vladikoff vladikoff deleted the yaml-refactor branch Aug 18, 2020
@vladikoff
Copy link
Member Author

@vladikoff vladikoff commented Aug 18, 2020

Thank you @shama !!! 馃巵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.