Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for no-beep #843

Closed
wants to merge 1 commit into from
Closed

Add option for no-beep #843

wants to merge 1 commit into from

Conversation

MCluck90
Copy link

Fixes #808 and allows anyone to disable the beeping sound while keeping their colored output.

@shama
Copy link
Member

shama commented Jul 12, 2013

Thanks for the PR! But closing as you can disable the audible bell in your console settings. Duplicate of #190 and #599.

@shama shama closed this Jul 12, 2013
@Aeal
Copy link

Aeal commented Jan 9, 2014

I don't understand why you would not add this option. Not all consoles have the ability to turn off the beep, and its a trivial feature that there seems to be a demand for.

@shama
Copy link
Member

shama commented Jan 9, 2014

There is already an option to disable the beep, --no-color. We share all cli options with every person that uses Grunt. So we shouldn't consume more options then we need. "I don't want the beep but I want colors and don't want to figure out how to disable the audible bell in my terminal" isn't exactly a pressing use case to consume more user cli options.

Especially because you can easily patch grunt.log.writeln to strip out '\x07' if your needs fit that use case.

@Aeal
Copy link

Aeal commented Jan 9, 2014

using one command to disable two options is really unintutive. Also maybe the user does not want to permanently switch off the console beep they would rather just have a switch to toggle it at runtime, and the argument that "you shouldn't consume more options than you need" is not a great argument for excluding it because you can just set a default value for it anyways. Also making someone patch your program for a feature that should be included everytime they want to use it is not exactly user friendly. In the end you can do what you want, but adding the feature will make it a better product.

@shama
Copy link
Member

shama commented Jan 9, 2014

While I don't agree (and think Grunt should totally be focused on way more important issues), it looks like the Grunt team is changing it's stance on the infamous no-beep. From IRC today:

tkellen #843 i think we should support this, it's simple and people want it and it doesn't really complicate anything /cc ben_alman shama
ben_alman sure
ben_alman add it to the list

@worc
Copy link

worc commented Sep 23, 2015

i found a lone edge case here where running grunt in Webstorm's integrated terminal will beep despite system settings. --no-color is still my workaround, but it'd be nice to to have color and no-beep instead of no-color and no-beep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize Beep Sound (Windows)
4 participants