Feat: Detekt and Test Plugins, (Including Create Detekt Baseline) #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephSanjaya
force-pushed
the
js/feat/build-logic-test
branch
2 times, most recently
from
0194733 to
08ae6a4
Compare
kcw-grunt
reviewed
Sep 20, 2025
Yup agreed, this is baseline file, will try to reduce the chnges |
|
I will convert this to draft first, please check https://github.com/gruntsoftware/android-games/pull/5 this PR so i can use latest commit hash for this PR later. |
I tried to modify the configuration but turn out the flow in detekt Baseline is:
|
JosephSanjaya
force-pushed
the
js/feat/build-logic-test
branch
from
08ae6a4 to
ddfff43
Compare
Integrates the `gruntsoftware-build-logic` Git submodule into the project. This change includes: - Adding the submodule to `.gitmodules`. - Including the build logic in `settings.gradle.kts`. - Applying build logic plugins (`test` and `detekt`) in `app/build.gradle.kts`.
This commit removes the ktlint configuration and associated tasks from the `app/build.gradle.kts` file. It also removes the `pinterest-ktlint` dependency from the `gradle/libs.versions.toml` file.
JosephSanjaya
force-pushed
the
js/feat/build-logic-test
branch
from
ddfff43 to
b37c385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📱 Description
Integrate buildlogic for detekt and test
Platform
🎯 Type of Change
📋 Changes
🔗 Related Issues
🧪 Tests Status
🎯 Reviewers
@kcw-grunt, @josikie