Fix paragraph spacing in Guides #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This quick PR addresses the overly tight (lack of) spacing between some paragraphs in our guides. The way that the CSS is structured in this product leaves many ways in which inconsistency can be introduced. I'm not going to deal with the larger issues in this PR but will simply address the problem.
eak12913
requested review from
josh-padnick,
oredavids and
tsmit291
as code owners
|
✔️ Deploy preview for keen-clarke-470db9 ready! 🔨 Explore the source changes: d9ba17f 🔍 Inspect the deploy logs: https://app.netlify.com/sites/keen-clarke-470db9/deploys/5fce4b16e4e44e00089ac40f 😎 Browse the preview: https://deploy-preview-379--keen-clarke-470db9.netlify.app |
Merged
Contributor
|
Reviewing this some 3 weeks later, but this looks good. Will approve now! |
josh-padnick
approved these changes
Dec 7, 2020
Contributor
Author
|
@oredavids: I somehow missed this PR. Josh approved it a week ago but he also updated the branch. Could you please approve this PR so that we could just merge it. Thank you! |
Contributor
Author
|
Thanks @infraredgirl! |
Contributor
Author
|
Released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This quick PR addresses the overly tight (lack of) spacing between some paragraphs in our guides. The way that the CSS is structured in this product leaves many ways in which inconsistency can be introduced. I'm not going to deal with the larger issues in this PR but will simply address the problem.
Before:
After:
