-
-
Notifications
You must be signed in to change notification settings - Fork 42
[WWW-109] Intercom removed #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WWW-109] Intercom removed #382
Conversation
|
✔️ Deploy preview for keen-clarke-470db9 ready! 🔨 Explore the source changes: c0a15a3 🔍 Inspect the deploy logs: https://app.netlify.com/sites/keen-clarke-470db9/deploys/5fda3cb742bd4d00082a2879 😎 Browse the preview: https://deploy-preview-382--keen-clarke-470db9.netlify.app |
eak12913
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there's also a mention of Intercom in cookie-policy.yml. There's also a comment mention in cookies.js which should be updated in order to avoid confusion later. Thanks!
eak12913
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @klijakub, I'm going to approve this PR but I'd like @josh-padnick to weigh in on what to do about the mention in the policy. He can make the final call on it but we should move forward in the mean time.
@josh-padnick once you're back from break - please take a look at #382 (comment) and let @klijakub know how to remove the mention of Intercom from that page.
|
Chiming in a few days later, but let's update the cookie policy as follows: Current: ## Customization cookies
These cookies enable us to provide unique or custom content based on your preferences, which may include special offers or content that you have shown interest in.
### Who Sets These Cookies:
Intercom, Inc. (https://intercom.com)
### How To Opt Out of Them:
See the section Opting out of cookies > Third-party cookies.New: ## Customization cookies
These cookies enable us to provide unique or custom content based on your preferences, which may include special offers or content that you have shown interest in.
We do not currently use any customization cookies. If we add any in the future, we will amend this cookie policy.Finally, we'll need to update https://gruntwork.io/legal/feed to add the following: 2020-12-07
cookie-policy
We've updated our cookie policy to remove Intercom, a vendor we previously used to enable real-time chat via our website.
https://github.com/gruntwork-io/gruntwork-io.github.io/commit/433dfbbNote that you should link to a git commit whose sole update is to remove Intercom from the cookie policy. So you'll really need two git commits here:
At that point, I think we should be all set here! |
|
@klijakub Could you tackle the items in my previous comment so we can get this merged? |
eak12913
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! @josh-padnick to close the loop here, do we need to cancel any subscription with Intercom?
|
Thank you, @klijakub. This looks great! Merging now. Eugene, I'll cancel Intercom next. |

Hello,
Jira Item: WWW-109