Skip to content

Conversation

@klijakub
Copy link
Contributor

Hello,

  1. The intercom chat window in the bottom right of the website is removed. ✅
  2. The site loads correctly without any errors that may have been caused by removing Intercom. ✅

Jira Item: WWW-109

@netlify
Copy link

netlify bot commented Nov 23, 2020

✔️ Deploy preview for keen-clarke-470db9 ready!

🔨 Explore the source changes: c0a15a3

🔍 Inspect the deploy logs: https://app.netlify.com/sites/keen-clarke-470db9/deploys/5fda3cb742bd4d00082a2879

😎 Browse the preview: https://deploy-preview-382--keen-clarke-470db9.netlify.app

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's also a mention of Intercom in cookie-policy.yml. There's also a comment mention in cookies.js which should be updated in order to avoid confusion later. Thanks!

@klijakub
Copy link
Contributor Author

I believe there's also a mention of Intercom in cookie-policy.yml. There's also a comment mention in cookies.js which should be updated in order to avoid confusion later. Thanks!

Thanks for the review!
Yeah, I saw that, but don't know which part of the cookie policy you want to delete? The whole paragraph?
image

Cookie comment from cookie.js deleted ;)

eak12913
eak12913 previously approved these changes Nov 23, 2020
Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @klijakub, I'm going to approve this PR but I'd like @josh-padnick to weigh in on what to do about the mention in the policy. He can make the final call on it but we should move forward in the mean time.

@josh-padnick once you're back from break - please take a look at #382 (comment) and let @klijakub know how to remove the mention of Intercom from that page.

@josh-padnick
Copy link
Contributor

Chiming in a few days later, but let's update the cookie policy as follows:

Current:

## Customization cookies
These cookies enable us to provide unique or custom content based on your preferences, which may include special offers or content that you have shown interest in.

### Who Sets These Cookies:
Intercom, Inc. (https://intercom.com)

### How To Opt Out of Them:
See the section Opting out of cookies > Third-party cookies.

New:

## Customization cookies
These cookies enable us to provide unique or custom content based on your preferences, which may include special offers or content that you have shown interest in.

We do not currently use any customization cookies. If we add any in the future, we will amend this cookie policy.

Finally, we'll need to update https://gruntwork.io/legal/feed to add the following:

2020-12-07

cookie-policy

We've updated our cookie policy to remove Intercom, a vendor we previously used to enable real-time chat via our website.
https://github.com/gruntwork-io/gruntwork-io.github.io/commit/433dfbb

Note that you should link to a git commit whose sole update is to remove Intercom from the cookie policy. So you'll really need two git commits here:

  1. Remove Intercom from cookie policy
  2. Update legal feed

At that point, I think we should be all set here!

@josh-padnick
Copy link
Contributor

@klijakub Could you tackle the items in my previous comment so we can get this merged?

Copy link
Contributor

@eak12913 eak12913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! @josh-padnick to close the loop here, do we need to cancel any subscription with Intercom?

@josh-padnick
Copy link
Contributor

Thank you, @klijakub. This looks great! Merging now. Eugene, I'll cancel Intercom next.

@josh-padnick josh-padnick merged commit d6221d2 into gruntwork-io:master Dec 21, 2020
@josh-padnick josh-padnick deleted the WWW-109-Remove-Intercom branch December 21, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants