Create TF 0.13 upgrade guide #384

brikis98 · 2020-12-16T14:38:34Z

This PR adds an upgrade guide for using Terraform 0.13. This is still a WIP as I need to update the Acme repos and fill in the links for those. That said, an early review of the content that's here now is very welcome!

Direct link: https://deploy-preview-384--keen-clarke-470db9.netlify.app/guides/upgrades/how-to-update-to-terraform-13/

netlify · 2020-12-16T14:39:46Z

✔️ Deploy preview for keen-clarke-470db9 ready!

🔨 Explore the source changes: 1256f4a

🔍 Inspect the deploy logs: https://app.netlify.com/sites/keen-clarke-470db9/deploys/5fdb90a4d84d0c00078f09e5

😎 Browse the preview: https://deploy-preview-384--keen-clarke-470db9.netlify.app

brikis98 · 2020-12-16T14:42:00Z

@eak12913 @oredavids Any idea why my new guide doesn't show up in the list? https://deploy-preview-384--keen-clarke-470db9.netlify.app/guides

I'm able to get to the guide by manually plugging in the URL: https://deploy-preview-384--keen-clarke-470db9.netlify.app/guides/upgrades/how-to-update-to-terraform-13/

eak12913 · 2020-12-16T14:43:30Z

I'm looking now. In the past, such issues were usually caused by something that either Jekyll or our search logic didn't like about the title.

brikis98 · 2020-12-16T14:44:43Z

Hm... Also, hot reload isn't working locally. When I make a change to the file and hit save, Jekyll isn't reloading automatically...

Jekyll or our search logic doesn't like any special characters in the name of the post

brikis98 · 2020-12-16T14:46:33Z

OK, looks like it doesn't show up in the list because the title had 0.13 in it. I replaced it with just 13 and it works.

Not sure on the hot reload issue though.

eak12913 · 2020-12-16T14:49:51Z

Also, hot reload isn't working locally. When I make a change to the file and hit save, Jekyll isn't reloading automatically...

I just verified locally and it's working for me. I added the "." back into the title and it rebuilt. My logs looked like:

        LiveReload: Browser connected
      Regenerating: 1 file(s) changed at 2020-12-16 06:48:16
                    _posts/2020-12-16-how-to-update-to-terraform-13.adoc
       Jekyll Feed: Generating feed for posts
                    ...done in 1.296426 seconds.

      Regenerating: 1 file(s) changed at 2020-12-16 06:48:33
                    _posts/2020-12-16-how-to-update-to-terraform-13.adoc
       Jekyll Feed: Generating feed for posts
                    ...done in 1.264484 seconds.

brikis98 · 2020-12-16T14:50:36Z

Also, hot reload isn't working locally. When I make a change to the file and hit save, Jekyll isn't reloading automatically...

I just verified locally and it's working for me. I added the "." back into the title and it rebuilt. My logs looked like:
        LiveReload: Browser connected
      Regenerating: 1 file(s) changed at 2020-12-16 06:48:16
                    _posts/2020-12-16-how-to-update-to-terraform-13.adoc
       Jekyll Feed: Generating feed for posts
                    ...done in 1.296426 seconds.

      Regenerating: 1 file(s) changed at 2020-12-16 06:48:33
                    _posts/2020-12-16-how-to-update-to-terraform-13.adoc
       Jekyll Feed: Generating feed for posts
                    ...done in 1.264484 seconds.

I have the same up to the "LiveReload: Browser connected" thing... But after changes, the "Regenerating" never appears. Note that I'm running via docker-compose up.

eak12913 · 2020-12-16T14:51:47Z

Ah - that must be the difference. I am just running ./jekyll-serve locally.

brikis98 · 2020-12-16T14:53:21Z

Ah - that must be the difference. I am just running ./jekyll-serve locally.

Ruby versioning and dependencies are a freaking nightmare, so I try to never install/run locally. The docker-compose thing I've used for years with a dozen Jekyll sites and it worked fine. What changed?

eak12913 · 2020-12-16T14:58:04Z

Looking now. I see that docker compose exposes ports 4000 and 35729 for serving the app and live reloads. The dockerfile only has EXPOSE 4000. I am trying now to add EXPOSE 35729 and see if that resolves the issue.

We haven't made changes here lately - so I'm not sure what the matter is

eak12913 · 2020-12-16T18:13:33Z

Hey Jim (@brikis98) - I'm actually not able to repro your issue locally even after running the thing with docker-compose. I dont think my suggestion above had anything to do with your problem as things work for me even if I don't expose the extra port like I was suggesting above.

brikis98 · 2020-12-17T08:50:50Z

Hey Jim (@brikis98) - I'm actually not able to repro your issue locally even after running the thing with docker-compose. I dont think my suggestion above had anything to do with your problem as things work for me even if I don't expose the extra port like I was suggesting above.

Hm, not sure what the issue is. Maybe some Docker version thing? It's not urgent, so I'll have to come back to this.

_posts/2020-12-16-how-to-update-to-terraform-13.adoc

Co-authored-by: Ina Stoyanova <ina@gruntwork.io>

_posts/2020-12-16-how-to-update-to-terraform-13.adoc

…k-io.github.io into tf13-upgrade-guide

yorinasub17

LGTM other than the one note about reminding folks to update to the last version prior to tf13.

yorinasub17 · 2020-12-17T16:35:23Z

_posts/2020-12-16-how-to-update-to-terraform-13.adoc

+[[deployment_walkthrough]]
+== Deployment walkthrough
+
+=== Step 1: update your code to be compatible with Terraform 0.13


I think Step 1 should be to update their module versions to the version right before tf13 and update to terraform 0.12.26. This is especially true for EKS modules, where the upgrade to 0.13 compatible module version assumes you have updated to the last release since we remove some version compatibility features for the old ingress controller.

Good idea. Done: 583a89b

yorinasub17

LGTM!

brikis98 · 2020-12-17T17:09:19Z

Sorry, had one last push to update the CIS PR links. Could I get one more "ship it"?

brikis98 · 2020-12-17T17:18:47Z

Thank you! Merging and releasing now.

Create initial TF 0.13 upgrade guide

70c17d4

brikis98 requested review from eak12913, josh-padnick, oredavids and tsmit291 as code owners December 16, 2020 14:38

brikis98 added 2 commits December 16, 2020 14:45

Remove 0. from the name

35b84d7

Jekyll or our search logic doesn't like any special characters in the name of the post

Remove accidental line of text

d547387

Fix AsciiDoc comment syntax

582675b

Add note on upgrading and EKS

1e03598

ina-stoyanova reviewed Dec 17, 2020

View reviewed changes

_posts/2020-12-16-how-to-update-to-terraform-13.adoc Outdated Show resolved Hide resolved

Update _posts/2020-12-16-how-to-update-to-terraform-13.adoc

afa8d84

Co-authored-by: Ina Stoyanova <ina@gruntwork.io>

ina-stoyanova reviewed Dec 17, 2020

View reviewed changes

_posts/2020-12-16-how-to-update-to-terraform-13.adoc Show resolved Hide resolved

brikis98 added 2 commits December 17, 2020 13:33

Update standard Ref Arch links

eb01fa7

Merge branch 'tf13-upgrade-guide' of github.com:gruntwork-io/gruntwor…

8d95db4

…k-io.github.io into tf13-upgrade-guide

yorinasub17 previously approved these changes Dec 17, 2020

View reviewed changes

Update instructions with a step to update to 0.12 first

583a89b

brikis98 dismissed yorinasub17’s stale review via 583a89b December 17, 2020 16:58

yorinasub17 previously approved these changes Dec 17, 2020

View reviewed changes

Update links to CIS repos

1256f4a

brikis98 dismissed yorinasub17’s stale review via 1256f4a December 17, 2020 17:08

brikis98 changed the title ~~[WIP] Create TF 0.13 upgrade guide~~ Create TF 0.13 upgrade guide Dec 17, 2020

infraredgirl approved these changes Dec 17, 2020

View reviewed changes

brikis98 merged commit 1960dde into master Dec 17, 2020

brikis98 deleted the tf13-upgrade-guide branch December 17, 2020 17:18

Uh oh!

Create TF 0.13 upgrade guide #384

Create TF 0.13 upgrade guide #384

Uh oh!

Conversation

brikis98 commented Dec 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Dec 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brikis98 commented Dec 16, 2020

Uh oh!

eak12913 commented Dec 16, 2020

Uh oh!

brikis98 commented Dec 16, 2020

Uh oh!

brikis98 commented Dec 16, 2020

Uh oh!

eak12913 commented Dec 16, 2020

Uh oh!

brikis98 commented Dec 16, 2020

Uh oh!

eak12913 commented Dec 16, 2020

Uh oh!

brikis98 commented Dec 16, 2020

Uh oh!

eak12913 commented Dec 16, 2020

Uh oh!

eak12913 commented Dec 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brikis98 commented Dec 17, 2020

Uh oh!

Uh oh!

Uh oh!

yorinasub17 left a comment

Choose a reason for hiding this comment

Uh oh!

yorinasub17 Dec 17, 2020

Choose a reason for hiding this comment

Uh oh!

brikis98 Dec 17, 2020

Choose a reason for hiding this comment

Uh oh!

yorinasub17 left a comment

Choose a reason for hiding this comment

Uh oh!

brikis98 commented Dec 17, 2020

Uh oh!

brikis98 commented Dec 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

brikis98 commented Dec 16, 2020 •

edited

Loading

netlify bot commented Dec 16, 2020 •

edited

Loading

eak12913 commented Dec 16, 2020 •

edited

Loading