Remove unnecessary package installation #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimenting with CircleCI config to address stability issues when trying to install OpenJDK8 onto the ruby-buster docker image.
eak12913
requested review from
josh-padnick,
oredavids and
tsmit291
as code owners
|
✔️ Deploy preview for keen-clarke-470db9 ready! 🔨 Explore the source changes: 84d6d78 🔍 Inspect the deploy logs: https://app.netlify.com/sites/keen-clarke-470db9/deploys/5ffde68714a8b800082e3eb4 😎 Browse the preview: https://deploy-preview-390--keen-clarke-470db9.netlify.app |
…ld in CircleCI fix the circleci config file more iteration more iteration.. more iteration.. more iteration.. more iteration.. more iteration.. more iteration.. more iteration.. more iteration.. more iteration.. more iteration.. more iteration.. more iteration.. more iteration.. more iteration..
… which were causing issues
eak12913
force-pushed
the
update-circleci-docker-image
branch
from
4028d4d to
efb600a
Compare
eak12913
changed the title
pete0emerson
approved these changes
Jan 12, 2021
Contributor
pete0emerson
left a comment
pete0emerson
left a comment
There was a problem hiding this comment.
I watched @eak12913 bang his head on this and we worked through it together in a paired session. We don't need gnupg any more, and gnupg was relying on systemd.
LGTM 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently been seeing errors when running our CI builds for this repo where a specific
systemddebian package was not able to be found. This was causing frustrating build failures and interfering with our production deploys.See context:
These errors turned out to be associated with installing a package that we don't need. So I have removed it.
The better solution here would be to switch this build to using a custom docker image that's already been pre-built with all necessary dependencies so that we don't have to keep re-installing things each time.