Updates on Landing Zone Guide #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marinalimeira
requested review from
eak12913,
josh-padnick,
oredavids and
tsmit291
as code owners
marinalimeira
requested review from
ina-stoyanova,
infraredgirl and
robmorgan
|
Deploy preview for keen-clarke-470db9 ready! Built with commit 846a9b1 |
brikis98
reviewed
Feb 17, 2021
Member
brikis98
left a comment
brikis98
left a comment
There was a problem hiding this comment.
Thx for the fixes! It's def a good improvement, but we need to sanity check all the releases between v0.36.0 to v0.44.10 to make sure no input/output vars were removed, renamed, or new required ones added.
_posts/2019-08-12-how-to-configure-production-grade-aws-account-structure.adoc
Outdated
Show resolved
Hide resolved
Contributor
|
All, are we ready to merge this? What remains to be done? |
Contributor
|
Bump. @brikis98 Any thoughts on if we can merge this? |
Contributor
Author
|
Sorry for the delay. I am coming back to this one now. |
marinalimeira
dismissed stale reviews from rhoboat and ina-stoyanova
via
846a9b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will probably conflict with #387 but the changes are smaller and we can merge soon.
I hit those while deploying the guide by myself. I also hit this error that Rho also mention here. Maybe we add a section for it?