apply-all does not set auto-approve parameter

[dewang]

As of Terraform v0.11, the default behaviour for terraform apply is to show the plan and wait for approval. When using apply-all this results in the script waiting for input for every module that you want to deploy.

[brikis98]

Well, apply-all just runs apply in every directory, so it inherits whatever behavior Terraform has for apply. If you want it to be fully non-interactive, can't you just run terragrunt apply-all -auto-approve?

[dewang]

Interesting, I didn't think the parameter would be passed through. The stack sets -input=false

terragrunt/configstack/stack.go

Line 73 in bc8bae6

stack.setTerraformCommand([]string{"apply", "-input=false"})

so I assumed the -auto-approve would have to be passed the same way.
I can't imagine that anyone using apply-all would not want it to be fully non-interactive.

Having said all that, I have to say a massive thanks for terragrunt and also your blog posts. They've really helped me get set up with terraform.

[brikis98]

Interesting, I didn't think the parameter would be passed through. The stack sets -input=false

I believe the setTerraformCommand method appends your CLI args to the passed-in command, so it should work. Try it out and let me know!

Having said all that, I have to say a massive thanks for terragrunt and also your blog posts. They've really helped me get set up with terraform.

Thanks :)

[ebarault]

Just faced the same problem and tested vanilla terraform option -auto-approve : it does work 👍

That being said it really make the --terragrunt-non-interactive flag confusing since terraform v0.11.

Shouldn't the -auto-approve as well as -force options be added as well when using --terragrung-non-interactive ?

[brikis98]

Shouldn't the -auto-approve as well as -force options be added as well when using --terragrung-non-interactive ?

I could go either way on this one, but probably setting -auto-approve to true would be following "principle of least surprise."

What is -force?

[ebarault]

-force: cli option for destroy

"If -force is set, then the destroy confirmation will not be shown"

[brikis98]

Ah, I see. Give how destructive destroy is, I'd rather NOT include -force. It may be a mild annoyance for users, but easily solved by adding that parameter in; the opposite situation, where you didn't realize -force would be included automatically would be much worse!

[ebarault]

agreed 2017-12-05 17:22 GMT+01:00 Yevgeniy Brikman <notifications@github.com>:

…

Ah, I see. Give how destructive destroy is, I'd rather NOT include -force. It may be a mild annoyance for users, but easily solved by adding that parameter in; the opposite situation, where you didn't realize -force would be included automatically would be much worse! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#386 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALcep8Sph-PK1EAFIuVwcQfNitBnnwwqks5s9W28gaJpZM4Qx5_2> .

[robinbowes]

Another vote for adding -auto-approve when using apply-all. Without it, you end up with the terraform prompts getting lost when terragrunt runs multiple instances in parallel. It really makes no sense not to have -auto-approve with apply-all even when not using --terragrunt-non-interactive

[brikis98]

Without it, you end up with the terraform prompts getting lost when terragrunt runs multiple instances in parallel.

Ah, yea, that's a good point.

I'd welcome a PR to add this.

[mhumeSF]

Built locally and tested in my on use case. Works great though.
#407

[brikis98]

Fixed by @mhumeSF in #407. Thx!